Skip to content

Fix oversizeArrayType->isSubTypeOf #4407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2025
Merged

Fix oversizeArrayType->isSubTypeOf #4407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74b397d
Fix oversizeArrayType->isSubTypeOf
VincentLanglet Oct 4, 2025
2661d96
More
VincentLanglet Oct 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/Type/IntersectionType.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,10 +247,12 @@ public function isSubTypeOf(Type $otherType): IsSuperTypeOfResult
}

$result = IsSuperTypeOfResult::maxMin(...array_map(static fn (Type $innerType) => $otherType->isSuperTypeOf($innerType), $this->types));
if ($this->isOversizedArray()->yes()) {
if (!$result->no()) {
return IsSuperTypeOfResult::createYes();
}
if (
!$result->no()
&& $this->isOversizedArray()->yes()
&& !$otherType->isIterableAtLeastOnce()->no()
) {
return IsSuperTypeOfResult::createYes();
}

return $result;
Expand Down
88 changes: 88 additions & 0 deletions tests/PHPStan/Analyser/nsrt/bug-13509.php
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,88 @@
<?php declare(strict_types = 1);

namespace Bug13509;

use function PHPStan\Testing\assertType;

/** @return ?array<string, mixed> */
function alert(): ?array
{
$alerts = [];

if (rand()) {
$alerts[] = [
'message' => "Foo",
'details' => "bar",
'duration' => rand() ?: null,
'severity' => 100,
];
}

if (rand()) {
$alerts[] = [
'message' => 'Offline',
'duration' => rand() ?: null,
'severity' => 99,
];
}

if (rand()) {
$alerts[] = [
'message' => 'Running W/O Operator',
'duration' => rand() ?: null,
'severity' => 75,
];
}

if (rand()) {
$alerts[] = [
'message' => 'No Queue',
'duration' => rand() ?: null,
'severity' => 60,
];
}

if (rand()) {
if (rand()) {
$alerts[] = [
'message' => 'Not Scheduled',
'duration' => null,
'severity' => 25,
];
}

if (rand()) {
$alerts[] = [
'message' => 'On Lunch',
'duration' => rand() ?: null,
'severity' => 24,
];
}

if (rand()) {
$alerts[] = [
'message' => 'On Break',
'duration' => rand() ?: null,
'severity' => 24,
];
}
}

if (rand()) {
$alerts[] = [
'message' => 'Idle',
'duration' => rand() ?: null,
'severity' => 23,
];
}

if ($alerts === []) {
return null;
}

assertType('non-empty-list<non-empty-array<literal-string&lowercase-string&non-falsy-string, int|(literal-string&non-falsy-string)|null>&oversized-array>&oversized-array', $alerts);

usort($alerts, fn ($a, $b) => $b['severity'] <=> $a['severity']);

return $alerts[0];
}
6 changes: 6 additions & 0 deletions tests/PHPStan/Type/TypeCombinatorTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5331,6 +5331,12 @@ public static function dataRemove(): array
ObjectShapeType::class,
'object{foo?: int}',
],
[
new IntersectionType([new ArrayType(new StringType(), new StringType()), new OversizedArrayType()]),
new ConstantArrayType([], []),
IntersectionType::class,
'non-empty-array<string, string>&oversized-array',
],
];
}

Expand Down
Loading