Fix too wide bool in trivial methods #4444
Open
+60
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ondrejmirtes
requested changes
Oct 16, 2025
ondrejmirtes
requested changes
Oct 17, 2025
There was a problem hiding this comment.
You've deleted a bunch of test assertions. Right now there are vast areas of the code that aren't covered by proper tests.
What needs to happen first is to change the current tests so they continue to be reported.
Then you can add your own tests for code that shouldn't be reported. Thanks.
staabm
force-pushed
the
bug13482
branch
2 times, most recently
from
b1c88e0 to
e1b8456
Compare
|
@ondrejmirtes great feedback thanks. adjusted the tests accordingly. |
…onReturnTypehintRuleTest.php
…ReturnTypehintRuleTest.php
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes phpstan/phpstan#13482