TypeCombinatorTest: turn return
into yield
#4451
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used rector to transform the test. I think its way more readable to have a single
yield
per test-case instead of a hugereturn [[], [], []]
in which its hard to see where test-data from one test starts and where the next one starts etc.just did the transformation on a single test for now, to discuss the overall idea.
this PR did not transform the
yield from [[], [], []]
intoyield
, as this is not yet implemented in rector.wdyt?