Skip to content

Conversation

@staabm
Copy link
Contributor

@staabm staabm commented Nov 17, 2025

No description provided.

@ondrejmirtes
Copy link
Member

This failure on 7.4 is related to your PR:


1) PHPStan\Analyser\Bug13813IntegrationTest::testBug13813
Failed asserting that two strings are identical.
--- Expected
+++ Actual
@@ @@
-'Warning: Undefined variable $x'
+'Notice: Undefined variable: x'

@ondrejmirtes
Copy link
Member

I know it's not great the build is currently red, I'm very deep in GNSR right now and I'm gonna fix that 😊

@staabm
Copy link
Contributor Author

staabm commented Nov 17, 2025

ohh you are right. sorry that I did not notice it earlier.

@ondrejmirtes ondrejmirtes merged commit e4199a4 into phpstan:2.1.x Nov 17, 2025
328 of 345 checks passed
@ondrejmirtes
Copy link
Member

Thank you!

@staabm
Copy link
Contributor Author

staabm commented Nov 17, 2025

another CS error slipped in ;)

@staabm
Copy link
Contributor Author

staabm commented Nov 17, 2025

could you fix it while working on GNSR or should I send another PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants