Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use PHPStan\DependencyInjection\AutowiredService;
use PHPStan\Reflection\AllowedSubTypesClassReflectionExtension;
use PHPStan\Reflection\ClassReflection;
use PHPStan\Type\ObjectType;
use PHPStan\Type\UnionType;
use function count;

Expand All @@ -30,6 +31,10 @@ public function getAllowedSubTypes(ClassReflection $classReflection): array
}
}

if ($classReflection->isClass() && !$classReflection->isAbstract()) {
$types[] = new ObjectType($classReflection->getName());
}

return $types;
}

Expand Down
5 changes: 5 additions & 0 deletions tests/PHPStan/Rules/Classes/AllowedSubTypesRuleTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,11 @@ public function testSealed(): void
]);
}

public function testSealedOnConcreteClass(): void
{
$this->analyse([__DIR__ . '/data/sealed_concrete.php'], []);
}

public static function getAdditionalConfigFiles(): array
{
return [
Expand Down
35 changes: 35 additions & 0 deletions tests/PHPStan/Rules/Classes/data/sealed_concrete.php
Original file line number Diff line number Diff line change
@@ -0,0 +1,35 @@
<?php declare(strict_types = 1);

namespace SealedConcrete;

use function PHPStan\Testing\assertType;

/**
* @phpstan-sealed a|b|c
*/
class s {}

final class a extends s {}
final class b extends s {}
final class c extends s {}

function foo(s $sealedClass): void
{
if ($sealedClass instanceof a) {
return;
}

assertType('SealedConcrete\\s~SealedConcrete\\a', $sealedClass);

if ($sealedClass instanceof b) {
return;
}

assertType('SealedConcrete\\s~(SealedConcrete\\a|SealedConcrete\\b)', $sealedClass);

if ($sealedClass instanceof c) {
return;
}

assertType('SealedConcrete\\s', $sealedClass);
}
Loading