fix: prefer create the default type manually instead

Author: Kocal

composer.json

@@ -26,9 +26,9 @@
     "phpstan/phpstan-phpunit": "^0.12.16",
     "phpstan/phpstan-strict-rules": "^0.12.5",
     "phpunit/phpunit": "^7.5.20",
-    "symfony/console": "^4.0 || ^5.0",
     "symfony/config": "^4.2 || ^5.0",
-    "symfony/framework-bundle": "^4.0 || ^5.0",
+    "symfony/console": "^4.0 || ^5.0",
+    "symfony/framework-bundle": "^4.4 || ^5.0",
     "symfony/http-foundation": "^4.0 || ^5.0",
     "symfony/messenger": "^4.2 || ^5.0",
     "symfony/serializer": "^4.0 || ^5.0"

src/Type/Symfony/ParameterDynamicReturnTypeExtension.php

@@ -8,9 +8,17 @@
 use PHPStan\Reflection\ParametersAcceptorSelector;
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Symfony\ParameterMap;
+use PHPStan\Type\ArrayType;
+use PHPStan\Type\BooleanType;
 use PHPStan\Type\Constant\ConstantBooleanType;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
+use PHPStan\Type\FloatType;
+use PHPStan\Type\IntegerType;
+use PHPStan\Type\MixedType;
+use PHPStan\Type\NullType;
+use PHPStan\Type\StringType;
 use PHPStan\Type\Type;
+use PHPStan\Type\UnionType;
 use function in_array;
 
 final class ParameterDynamicReturnTypeExtension implements DynamicMethodReturnTypeExtension
@@ -71,7 +79,16 @@ private function getGetTypeFromMethodCall(
 		Scope $scope
 	): Type
 	{
-		$returnType = ParametersAcceptorSelector::selectSingle($methodReflection->getVariants())->getReturnType();
+		// We don't use the method's return type because this won't work properly with lowest and
+		// highest versions of Symfony ("mixed" for lowest, "array|bool|float|integer|string|null" for highest).
+		$returnType = new UnionType([
+			new ArrayType(new MixedType(), new MixedType()),
+			new BooleanType(),
+			new FloatType(),
+			new IntegerType(),
+			new StringType(),
+			new NullType(),
+		]);
 		if (!isset($methodCall->args[0])) {
 			return $returnType;
 		}

tests/Type/Symfony/data/ExampleAbstractController.php

@@ -26,7 +26,7 @@ public function services(): void
 	public function parameters(ContainerInterface $container, ParameterBagInterface $parameterBag): void
 	{
 		assertType('array|bool|float|int|string|null', $container->getParameter('unknown'));
-		assertType('mixed', $parameterBag->get('unknown'));
+		assertType('array|bool|float|int|string|null', $parameterBag->get('unknown'));
 		assertType('array|bool|float|int|string|null', $this->getParameter('unknown'));
 		assertType("'abcdef'", $container->getParameter('app.string'));
 		assertType("'abcdef'", $parameterBag->get('app.string'));