styles

Author: Kocal

src/Symfony/FakeParameterMap.php

@@ -25,4 +25,5 @@ public static function getParameterKeyFromNode(Expr $node, Scope $scope): ?strin
 	{
 		return null;
 	}
+
 }

src/Symfony/Parameter.php

@@ -7,10 +7,12 @@ final class Parameter implements ParameterDefinition
 
 	/** @var string */
 	private $key;
+
 	/** @var array<mixed>|bool|float|int|string */
 	private $value;
 
 	/**
+	 * @param string $key
 	 * @param array<mixed>|bool|float|int|string $value
 	 */
 	public function __construct(
@@ -27,6 +29,9 @@ public function getKey(): string
 		return $this->key;
 	}
 
+	/**
+	 * @return array<mixed>|bool|float|int|string
+	 */
 	public function getValue()
 	{
 		return $this->value;

src/Symfony/XmlParameterMapFactory.php

@@ -1,4 +1,4 @@
-<?php declare(strict_types=1);
+<?php declare(strict_types = 1);
 
 namespace PHPStan\Symfony;
 
@@ -61,7 +61,7 @@ private function getNodeValue(\SimpleXMLElement $def)
 			case 'collection':
 				$value = [];
 				foreach ($def->children() as $child) {
-					/** @var \SimpleXMLElement $attrs */
+					/** @var \SimpleXMLElement $childAttrs */
 					$childAttrs = $child->attributes();
 
 					if (isset($childAttrs->key)) {
@@ -77,8 +77,9 @@ private function getNodeValue(\SimpleXMLElement $def)
 				break;
 
 			case 'binary':
-				if (false === $value = base64_decode((string) $def, true)) {
-					throw new \InvalidArgumentException(sprintf('Tag "<%s>" with type="binary" is not a valid base64 encoded string.', (string) $attrs->key));
+				$value = base64_decode((string) $def, true);
+				if ($value === false) {
+					throw new \InvalidArgumentException(sprintf('Parameter "%s" of binary type is not valid base64 encoded string.', (string) $attrs->key));
 				}
 
 				break;
@@ -87,18 +88,19 @@ private function getNodeValue(\SimpleXMLElement $def)
 				$value = (string) $def;
 
 				if (is_numeric($value)) {
-					if (false !== strpos($value, '.')) {
+					if (strpos($value, '.') !== false) {
 						$value = (float) $value;
 					} else {
 						$value = (int) $value;
 					}
-				} else if ($value === 'true') {
+				} elseif ($value === 'true') {
 					$value = true;
-				} else if ($value === 'false') {
+				} elseif ($value === 'false') {
 					$value = false;
 				}
 		}
 
 		return $value;
 	}
+
 }

src/Type/Symfony/ParameterDynamicReturnTypeExtension.php

@@ -9,9 +9,7 @@
 use PHPStan\ShouldNotHappenException;
 use PHPStan\Symfony\ParameterMap;
 use PHPStan\Type\Constant\ConstantBooleanType;
-use PHPStan\Type\ConstantTypeHelper;
 use PHPStan\Type\DynamicMethodReturnTypeExtension;
-use PHPStan\Type\ObjectType;
 use PHPStan\Type\Type;
 use function in_array;
 
@@ -33,7 +31,6 @@ final class ParameterDynamicReturnTypeExtension implements DynamicMethodReturnTy
 	/** @var \PHPStan\Symfony\ParameterMap */
 	private $parameterMap;
 
-
 	public function __construct(string $className, ?string $methodGet, ?string $methodHas, bool $constantHassers, ParameterMap $symfonyParameterMap)
 	{
 		$this->className = $className;
@@ -50,7 +47,7 @@ public function getClass(): string
 
 	public function isMethodSupported(MethodReflection $methodReflection): bool
 	{
-		$methods = array_filter([$this->methodGet, $this->methodHas], function(?string $method): bool {
+		$methods = array_filter([$this->methodGet, $this->methodHas], function (?string $method): bool {
 			return $method !== null;
 		});
 

tests/Symfony/DefaultParameterMapTest.php

@@ -109,7 +109,6 @@ function (?Parameter $parameter): void {
 					['name' => 'the name', 'value' => 'the value'],
 					['name' => 'another name', 'value' => 'another value'],
 				], $parameter->getValue());
-
 			},
 		];
 		yield [

tests/Type/Symfony/ExtensionTestWithoutContainer.php

@@ -14,9 +14,11 @@ public function dataFileAsserts(): iterable
 			yield from $this->gatherAssertTypes(__DIR__ . '/data/ExampleController.php');
 		}
 
-		if (class_exists('Symfony\Bundle\FrameworkBundle\Controller\AbstractController')) {
-			yield from $this->gatherAssertTypes(__DIR__ . '/data/ExampleAbstractController.php');
+		if (!class_exists('Symfony\Bundle\FrameworkBundle\Controller\AbstractController')) {
+			return;
 		}
+
+		yield from $this->gatherAssertTypes(__DIR__ . '/data/ExampleAbstractController.php');
 	}
 
 	/**

tests/Type/Symfony/data/ExampleAbstractController.php

@@ -25,9 +25,9 @@ public function services(): void
 
 	public function parameters(ContainerInterface $container, ParameterBagInterface $parameterBag): void
 	{
-		assertType('mixed', $container->getParameter('unknown'));
+		assertType('array|bool|float|int|string|null', $container->getParameter('unknown'));
 		assertType('mixed', $parameterBag->get('unknown'));
-		//assertType('mixed', $this->getParameter('unknown'));
+		//assertType('array|bool|float|int|string|null', $this->getParameter('unknown'));
 		assertType("'abcdef'", $container->getParameter('app.string'));
 		assertType("'abcdef'", $parameterBag->get('app.string'));
 		//assertType("'abcdef'", $this->getParameter('app.string'));

tests/Type/Symfony/data/ExampleController.php

@@ -25,9 +25,9 @@ public function services(): void
 
 	public function parameters(ContainerInterface $container, ParameterBagInterface $parameterBag): void
 	{
-		assertType('mixed', $container->getParameter('unknown'));
-		assertType('mixed', $parameterBag->get('unknown'));
-		//assertType('mixed', $this->getParameter('unknown'));
+		assertType('array|bool|float|int|string|null', $container->getParameter('unknown'));
+		assertType('array|bool|float|int|string|null', $parameterBag->get('unknown'));
+		//assertType('array|bool|float|int|string|null', $this->getParameter('unknown'));
 		assertType("'abcdef'", $container->getParameter('app.string'));
 		assertType("'abcdef'", $parameterBag->get('app.string'));
 		//assertType("'abcdef'", $this->getParameter('app.string'));