Allow custom module path normalisation #184
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Otherwise long module identifiers might get cut off.
This might be perfectly valid, if you're using a third-party module, which requires a module yet doesn't use it in the code paths hit and hence you just want to stub it out.
stesie
added a commit
that referenced
this pull request
Dec 6, 2015
Allow custom module path normalisation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the module path normalisation is done by V8Js itself in C++ code.
However, for example to load modules from a node.js module tree, it is required to influence the module path normalisation, as the files are scattered over sub directories and this needs to be taken into consideration.
Hence this allows to provide a custom normalisation routine, which overrides the V8Js default one, if set. Otherwise V8Js' default routine is used.