Windows support for V8 5.5+ #291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@stesie The transscript of the building process in README.Win32.md can be replaced by the description in #287 (comment) I will add the changes in the readme to this PR later. |
Member
|
great news :-) I already thought of pushing out a release this weekend, as the RSHUTDOWN fix isn't yet published. So I'll wait for your change and upload then. |
Contributor
Author
|
This must be it. Proof of the pudding: |
Member
|
Thank you very much @Jan-E as always :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are needed for building V8JS with V8 versions 5.5 and above. See #287 (comment)
Note: V8 version 5.5 and above produce 5 DLL's: v8.dll, v8_libbase.dll, v8_libplatform.dll plus icui18n.dll and icuuc.dll.