feat(TSE-950): Document comment_reactions endpoints#380
Merged
Mikko Karkee (Varpuspaavi) merged 5 commits intomasterfrom Aug 22, 2023
Merged
feat(TSE-950): Document comment_reactions endpoints#380Mikko Karkee (Varpuspaavi) merged 5 commits intomasterfrom
Mikko Karkee (Varpuspaavi) merged 5 commits intomasterfrom
Conversation
Mikko Karkee (Varpuspaavi)
requested review from
jablan and
Sönke Behrendt (theSoenke)
jablan
requested changes
Aug 18, 2023
Collaborator
jablan
left a comment
jablan
left a comment
There was a problem hiding this comment.
I believe CLI version needs to be 2.9, as that's where this endpoint will be available.
jablan
reviewed
Aug 18, 2023
| - Organization Job Templates | ||
| - Organization Job Template Locales | ||
| - Comments | ||
| - Comment reactions |
Collaborator
There was a problem hiding this comment.
IIRC some generated classes are named after these tags. Not sure whether it is affected by the case of the tags, but looking that all other tags are capitalized, I suggest renaming this to Comment Reactions, with both words capitalized.
jablan
approved these changes
Aug 22, 2023
This was referenced Aug 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/phrase/phrase/pull/11577
https://memsourcegroup.atlassian.net/browse/TSE-950