fix(API): Create Custom Metadata endpoint fix [TSI-2222]#499
Merged
Conversation
jablan
changed the title
| ProjectIds: []string{"project_id", "project_id2"}, | ||
| } | ||
| localVarOptionals := phrase.CustomMetadataPropertyCreateOpts{} | ||
| resp, httpRes, err := apiClient.CustomMetadataApi.CustomMetadataPropertyCreate(context.Background(), "account_id", customMetadataPropertiesCreateParameters, &localVarOptionals) |
Contributor
There was a problem hiding this comment.
Just one question passing customMetadataPropertiesCreateParameters here is equivalent to passing these arguments individually
(ctx _context.Context, accountId string, name string, dataType CustomMetadataDataType
in the actual api /clients/go/api_custom_metadata.go?
Collaborator
Author
There was a problem hiding this comment.
no, these individual arguments are replaced by this PR with CustomMetadataPropertiesCreateParameters struct. technically, it's a breaking change, but I don't think anyone is using this yet.
Hassan Ahmed (hahmed-dev)
approved these changes
Jan 2, 2024
This was referenced Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update Custom Metadata non-GET endpoints so that they comply with our standard way of passing parameters.