refactor!: add missing required params#571
Merged
Sönke Behrendt (theSoenke) merged 4 commits intomasterfrom Apr 23, 2024
Merged
refactor!: add missing required params#571Sönke Behrendt (theSoenke) merged 4 commits intomasterfrom
Sönke Behrendt (theSoenke) merged 4 commits intomasterfrom
Conversation
2806ceb to
b8a4e2a
Compare
b8a4e2a to
abe3926
Compare
1ee4b80 to
dfd983c
Compare
cdb0251 to
359db28
Compare
jablan
reviewed
Apr 19, 2024
jablan
reviewed
Apr 19, 2024
b4db842 to
622eadc
Compare
1ae4402 to
78d18ad
Compare
b1d3aa6 to
2010960
Compare
jablan
reviewed
Apr 22, 2024
32e7441 to
a8a313e
Compare
Hassan Ahmed (hahmed-dev)
approved these changes
Apr 22, 2024
This was referenced Apr 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improve documentation of required params. This will be a breaking change for some endpoints in the libraries and will be released in a new major version. It's not a breaking change for the REST API itself as these param were already required before and returned a 422 in case they were missing
The following endpoints now have additional required parameters:
authorizations#create-noteis requiredblacklisted_keys#create-nameis requiredbranches#create-nameis requireddistributions#create-name,project_idare requiredfigma_attachements#create-urlis requiredglossaries#create-nameis requiredglossary_term_translations#create-locale_code,contentare requiredglossary_terms#create-termis requiredinvitations#create-email,roleare requiredjobs#create-nameis requiredkeys#create-nameis requiredlocales#create-name,codeare requiredorders#create-name,lspare requiredprojects#create-nameis requiredscreenshot_markers#create-key_idis requiredspaces#create-nameis requiredstyleguides#create-titleis requiredtags#create-nameis requiredteams#add_project-idis requiredteam#add_space-idis requiredteams#add_user-idis requiredteams#create-nameis requiredtranslations#create-locale_id,key_idare requireduploads#create-file,file_format,locale_idare requiredvariables#create-nameis requiredwebhooks#create-callback_urlis required