fix(API): Comment creation schema fix #STRINGS-866#718
Merged
Conversation
jablan
requested review from
Sven Dunemann (forelabs) and
Sönke Behrendt (theSoenke)
Collaborator
|
jablan i believe for this endpoint it's specifically an issue because it passes an array via query params. Are there by any chance more endpoints with similar issues? 😅 And does it have an impact on the client interfaces? |
Collaborator
Author
|
Sönke Behrendt (@theSoenke) I searched quickly through all yeah, this impacts the client interfaces, but I'm not sure what we could do instead. this was a bug in schema description. |
Collaborator
|
jablan thanks for checking. Yeah, then this have to be a breaking change |
Sönke Behrendt (theSoenke)
approved these changes
Nov 20, 2024
This was referenced Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://phrase.atlassian.net/browse/STRINGS-866