Skip to content

fix(CLI): Adjust operationId for quality_performance_score #STRINGS-1104#721

Merged
Mikko Karkee (Varpuspaavi) merged 3 commits intomasterfrom
quality_performance_score
Jan 6, 2025
Merged

fix(CLI): Adjust operationId for quality_performance_score #STRINGS-1104#721
Mikko Karkee (Varpuspaavi) merged 3 commits intomasterfrom
quality_performance_score

Conversation

@Varpuspaavi
Copy link
Copy Markdown
Contributor

@Varpuspaavi Mikko Karkee (Varpuspaavi) commented Nov 25, 2024

#521 (comment)
https://phrase.atlassian.net/browse/STRINGS-1104

Screenshot 2025-01-03 at 11 31 03

phrase quality_performance_score list --data '{"translation_ids":["e2c4dd3a1955e2712847106551c7159c"]}' --project_id d2386d4294029615c29afecedb8139ff

Screenshot 2025-01-03 at 11 31 50

Comment thread clients/cli/go.sum
cloud.google.com/go/bigquery v1.8.0/go.mod h1:J5hqkt3O0uAFnINi6JXValWIb1v0goeZM77hZzJN/fQ=
cloud.google.com/go/datastore v1.0.0/go.mod h1:LXYbyblFSglQ5pkeyhO+Qmw7ukd3C+pD7TKLgZqpHYE=
cloud.google.com/go/datastore v1.1.0/go.mod h1:umbIZjpQpHh4hmRpGhH4tLFup+FVzqBi1b3c64qFpCk=
cloud.google.com/go/firestore v1.1.0/go.mod h1:ulACoGHTpvq5r8rxGJ4ddJZBZqakUQqClKRT5SZwBmk=
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated changes from building the clients

Comment thread clients/cli/go.mod Outdated
gopkg.in/ini.v1 v1.67.0 // indirect
)

require github.com/phrase/phrase-go/v3 v3.7.1
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated changes from building the clients

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you check your local files whether you still reference phrase-go/v3 somewhere? otherwise this line should no be here

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it was coming from some tmp files it seems 🙏

@Varpuspaavi Mikko Karkee (Varpuspaavi) changed the title chore: Adjust operationId for quality_performance_score fix: Adjust operationId for quality_performance_score Jan 3, 2025
@Varpuspaavi Mikko Karkee (Varpuspaavi) changed the title fix: Adjust operationId for quality_performance_score fix(CLI): Adjust operationId for quality_performance_score Jan 3, 2025
@Varpuspaavi Mikko Karkee (Varpuspaavi) changed the title fix(CLI): Adjust operationId for quality_performance_score fix(CLI, STRINGS-1104): Adjust operationId for quality_performance_score Jan 3, 2025
@Varpuspaavi
Copy link
Copy Markdown
Contributor Author

Should I merge the open PRs for bumps on the different repos before this one, or is there a reason they are still open?

@theSoenke
Copy link
Copy Markdown
Collaborator

Mikko Karkee (@Varpuspaavi) would be nice if you can merge them before. Even though it doesn't make a major difference as it would then just one patch release

@Varpuspaavi Mikko Karkee (Varpuspaavi) changed the title fix(CLI, STRINGS-1104): Adjust operationId for quality_performance_score fix(CLI): Adjust operationId for quality_performance_score #STRINGS-1104 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants