Skip to content

feat(API): Add 'default_encoding' documentation#733

Merged
Michael Blum (BlumMichael) merged 3 commits intomasterfrom
STRINGS-843-default-encoding
Dec 13, 2024
Merged

feat(API): Add 'default_encoding' documentation#733
Michael Blum (BlumMichael) merged 3 commits intomasterfrom
STRINGS-843-default-encoding

Conversation

@BlumMichael
Copy link
Copy Markdown
Contributor

@BlumMichael Michael Blum (BlumMichael) commented Dec 12, 2024

@BlumMichael Michael Blum (BlumMichael) changed the title Add 'default_encoding' documentation Chore (STRINGS-843) - Add 'default_encoding' documentation Dec 12, 2024
@BlumMichael Michael Blum (BlumMichael) changed the title Chore (STRINGS-843) - Add 'default_encoding' documentation chore(STRINGS-843) - Add 'default_encoding' documentation Dec 12, 2024
@BlumMichael Michael Blum (BlumMichael) changed the title chore(STRINGS-843) - Add 'default_encoding' documentation feat(API): Add 'default_encoding' documentation Dec 12, 2024
@BlumMichael Michael Blum (BlumMichael) requested a review from a team December 12, 2024 09:56
Comment thread paths/projects/update.yaml Outdated
@theSoenke
Copy link
Copy Markdown
Collaborator

Michael Blum (@BlumMichael) is the param also exposed via the show project endpoint and should be documented here?

@BlumMichael
Copy link
Copy Markdown
Contributor Author

Michael Blum (@BlumMichael) is the param also exposed via the show project endpoint and should be documented here?

It's not exposed via show-endpoint: https://github.com/phrase/phrase/blob/STRINGS-843-follow-up/app/serializers/project_serializer.rb

Comment thread paths/projects/update.yaml Outdated
@theSoenke
Copy link
Copy Markdown
Collaborator

Michael Blum (@BlumMichael) i think we should then also add it to the project show endpoint? if users want to set it they probably also want to check the current state :)

@jablan
Copy link
Copy Markdown
Collaborator

jablan commented Dec 12, 2024

Sönke Behrendt (@theSoenke) create too, I guess?

@BlumMichael
Copy link
Copy Markdown
Contributor Author

Michael Blum (@BlumMichael) i think we should then also add it to the project show endpoint? if users want to set it they probably also want to check the current state :)

Sönke Behrendt (@theSoenke)

None of the other settings (e.g. "smart_suggest_enabled", "enable_branching", "autotranslate_enabled", and so on) are available on the show endpoint. While I agree that it might be useful to have them there, I think it is out of scope for this ticket. Maybe lets create a separate task for that?

Example show-call

http://localhost:3000/api/v2/projects/6033a78e0e993a15409ec9d18fa93bb2

{
    "id": "6033a78e0e993a15409ec9d18fa93bb2",
    "name": "Strings-563",
    "slug": "strings-563",
    "main_format": "strings_json",
    "media": "",
    "shares_translation_memory": true,
    "project_image_url": null,
    "created_at": "2024-10-29T06:29:08Z",
    "updated_at": "2024-12-12T10:08:11Z",
    "account": {
        "id": "c1d4a2bcaa4aa8b8a0ec9f5cf23cc322",
        "name": "Phrase2",
        "slug": "phrase",
        "company": "",
        "created_at": "2024-08-08T06:31:46Z",
        "updated_at": "2024-12-10T08:51:17Z",
        "company_logo_url": null
    },
    "branch": null,
    "space": null,
    "point_of_contact": {
        "id": "66d2f0e1b74143a05630e79c9f4b0912",
        "username": "michael.blum+1000",
        "name": "Michael Blum",
        "gravatar_uid": "8c6376c873fdf69071a979f8e4be01b5"
    }
}

@theSoenke
Copy link
Copy Markdown
Collaborator

Michael Blum (@BlumMichael) sure, then let's make them all public in a follow-up task! ✅

@BlumMichael
Copy link
Copy Markdown
Contributor Author

Michael Blum (BlumMichael) commented Dec 12, 2024

Michael Blum (@BlumMichael) sure, then let's make them all public in a follow-up task! ✅

🙌
Created https://phrase.atlassian.net/browse/STRINGS-1029

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants