feat(API): Add create comparison endpoint for branches [SCD-549]#966
feat(API): Add create comparison endpoint for branches [SCD-549]#966Sönke Behrendt (theSoenke) merged 4 commits intomainfrom
Conversation
Efe Bikmaz (bikmazefe)
force-pushed
the
scd-549
branch
2 times, most recently
from
5b48b1d to
93ec4fc
Compare
Efe Bikmaz (bikmazefe)
requested review from
Sven Dunemann (forelabs) and
jablan
Efe Bikmaz (bikmazefe)
force-pushed
the
scd-549
branch
from
93ec4fc to
5ba36a1
Compare
| } | ||
| ], | ||
| "responses": { | ||
| "200": { |
There was a problem hiding this comment.
does API ever return 200 here?
There was a problem hiding this comment.
Ah it used to, but not anymore since we dropped the async switch param. Good catch, thanks!
| } | ||
| ], | ||
| "requestBody": { | ||
| "required": true, |
There was a problem hiding this comment.
is this required, considering that the only parameter is optional?
There was a problem hiding this comment.
It's not , but the pipeline is failing when this is set to false, I don't remember the exact location of the failure but I can trigger it again. I think that's why we don't have any required: false under requestBody in .yml files (at least I don't see any). I guess we'd need to check this separately 😬
| summary: Create comparison (async.) | ||
| description: | | ||
| Create a branch comparison asynchronously. | ||
| operationId: branch/create_comparison |
There was a problem hiding this comment.
This command looks a bit different than our other commands. Maybe branch/comparison/create would work too?
|
Important To be merged on Dec 10th |
Efe Bikmaz (bikmazefe)
requested review from
jablan and
Sönke Behrendt (theSoenke)
3 participants
Add create comparison endpoint for branches
https://phrase.atlassian.net/browse/SCD-549