Add state to Creatable to avoid mutating the options prop #2
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creatable
was mutating it's ownoptions
prop and throwing a TypeError. The best reason for this that I could find was that since React v14 they freeze props: https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes.Funny thing is I couldn't see anybody on the upstream react-select project complaining about this.
Since this is blocking me from using this component I went ahead and fixed it myself here.