Skip to content

Conversation

josh--newman
Copy link

Creatable was mutating it's own options prop and throwing a TypeError. The best reason for this that I could find was that since React v14 they freeze props: https://facebook.github.io/react/blog/2015/10/07/react-v0.14.html#breaking-changes.

Funny thing is I couldn't see anybody on the upstream react-select project complaining about this.

Since this is blocking me from using this component I went ahead and fixed it myself here.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.006%) to 88.72% when pulling 84a0466 on bugfix/dont-mutate-props into 405b575 on master.

@josh--newman josh--newman merged commit 6a86da9 into master Jul 24, 2017
@josh--newman josh--newman deleted the bugfix/dont-mutate-props branch July 24, 2017 18:45
@josh--newman josh--newman restored the bugfix/dont-mutate-props branch July 24, 2017 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants