Skip to content

SHELL env var assumed to exist during install #470

@maxrake

Description

@maxrake

Overview

When the install script is run in an environment where the SHELL environment variable is not set, the output includes a warning. This is not a failure of the script because it will still work. It is more just a blemish on the output, which may cause confusion with users who may think that an error has occurred.

Further, the instructions that get printed after install include a repeated word (file) when the SHELL env var is an unrecognized value.

How To Reproduce

Steps to reproduce this behavior:

  • Install the Phylum CLI in an environment where the SHELL environment variable is not set
    • This is the case in some/most CI systems (e.g., GitHub, GitLab, etc.)
    • unset the env var
  • See the error in the output:

Screen Shot 2022-06-15 at 6 38 53 PM


Expected Behavior

A sane default value is provided when there is no SHELL environment variable set.

Additional Context

N/A

Metadata

Metadata

Assignees

Labels

bugSomething isn't workinggood first issueGood for newcomerslow complexitySuitable for first time contributors.low priorityShould be handled as time permits

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions