fix: issue summary entries repeated in output#175
Merged
Conversation
It turns out that the possible risk domain names are mostly the same between how they are referenced between the project and package levels. The list of potential names was getting added to the list of flags, *without* checking for duplicates first. This was corrected by using a set instead of a list for the potential names. Additionally, the difference between `vulnerabilities` and `vulnerability` was confirmed to have been corrected in phylum-dev/api#424 and thus that entry was updated here as well. So, the only remaining difference is between `malicious_code` and `malicious`, which is being tracked with phylum-dev/api#499 Fixes #174
andreaphylum
approved these changes
Dec 19, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It turns out that the possible risk domain names are mostly the same between how they are referenced between the project and package levels. The list of potential names was getting added to the list of flags, without checking for duplicates first. This was corrected by using a set instead of a list for the potential names. Additionally, the difference between
vulnerabilitiesandvulnerabilitywas confirmed to have been corrected in phylum-dev/api#424 and thus that entry was updated here as well. So, the only remaining difference is betweenmalicious_codeandmalicious, which is being tracked with phylum-dev/api#499Fixes #174
Checklist
closes #<issueNum>in description above)?Have you created sufficient tests?Screenshots
Output from running the command:
poetry run phylum-ci -afl reqs.txt -p delme_repeat_check -u 100 -m 100 -e 100 -c 100 -o 100