Skip to content

fix: pre-commit hook failures#397

Merged
maxrake merged 5 commits into
mainfrom
fix_hook
Mar 4, 2024
Merged

fix: pre-commit hook failures#397
maxrake merged 5 commits into
mainfrom
fix_hook

Conversation

@maxrake
Copy link
Copy Markdown
Contributor

@maxrake maxrake commented Mar 1, 2024

Testing was performed locally and bug free functionality confirmed by updating poetry.lock with the latest dependencies and ensuring it passed the pre-commit hooks while submitting this change. Some small formatting changes were applied here. Guidance and implementation was updated to specify --no-cache when updating dependencies with Poetry. That way, the results will be the same regardless of where it happens (e.g., locally vs. CI).

Closes #394

It was discovered through local use that using the cache may not always
result in generating the same results as the CI environment for the same
command issued at the same time. Specifying the `--no-cache` option
ensures that the results generated are the same, regardless of where the
command is run.
@maxrake maxrake self-assigned this Mar 1, 2024
@maxrake maxrake requested a review from a team as a code owner March 1, 2024 04:38
@maxrake maxrake requested a review from cd-work March 1, 2024 04:38
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Mar 1, 2024

Phylum OSS Supply Chain Risk Analysis - SUCCESS

The Phylum risk analysis is complete and has passed the active policy.

View this project in the Phylum UI

@maxrake maxrake merged commit a6d0f5e into main Mar 4, 2024
@maxrake maxrake deleted the fix_hook branch March 4, 2024 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pre-commit hook failures when adding worktree

2 participants