Add CH569 USB3 microcontroller board PID files #800
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Jan 10, 2023
Collaborator
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Where is the bootloader source code? Hardware source looks good.
Contributor
Author
There is no bootloader source code yet. This is intended for the user of the board to use for his own bootloader, |
Collaborator
|
Why do you need a PID if there isn't any code that will use it? |
Signed-off-by: Hans Baier <hansfbaier@gmail.com>
Contributor
Author
OK, I removed the bootloader from the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just stress tested and verified the latest board revision. Works!
Ready for PID.
Signed-off-by: Hans Baier hansfbaier@gmail.com