Skip to content

Conversation

@424778940z
Copy link
Contributor

@424778940z 424778940z commented Feb 20, 2023

We requesting more than one PID because they are used in different modes of the device.

@424778940z 424778940z changed the title Add org: OneKeyInc and pid:4F4A,4F4B,4F4C Add org: OneKeyLtd and pid:4F4A,4F4B,4F4C Feb 20, 2023
Copy link
Collaborator

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to your open source hardware repo and have its README link to the software repo.

@424778940z
Copy link
Contributor Author

424778940z commented Mar 15, 2023

Please link to your open source hardware repo and have its README link to the software repo.

Sorry, my bad for not explain things in more details

Our hardware design and firmware source is in the same repository, there is no need to link to other repository
Firmware: https://github.com/OneKeyHQ/firmware/tree/bixin_dev/
Hardware: https://github.com/OneKeyHQ/firmware/tree/bixin_dev/docs/pcb

Our future device will also use the same PID and protocol, and it will have it's own repository. We also planning cleanning up current firmware repository and rename it to something make more sense. In the end, different devices will have it's own repository contains it's hardware desing and firmware source. Thus, we consider it is more proper to put link to our OneKeyHQ org instead of the current firmware repo for the url part, and then people could easily find things they are looking for

lf you have other opinion / suggestings I'm also happy to hear them

@tannewt
Copy link
Collaborator

tannewt commented Mar 20, 2023

Please link to the pcb directory from each pid page here. Otherwise it is hard to find. Please also add an explicit license to the pcb/ folder. It isn't clear what you intend because it is in the monorepo and LICENSE.md doesn't call out this folder.

Signed-off-by: Adam BZH <adam@onekey.so>
424778940z added a commit to OneKeyHQ/firmware that referenced this pull request Mar 23, 2023
424778940z added a commit to OneKeyHQ/firmware that referenced this pull request Mar 23, 2023
@424778940z
Copy link
Contributor Author

Please link to the pcb directory from each pid page here. Otherwise it is hard to find. Please also add an explicit license to the pcb/ folder. It isn't clear what you intend because it is in the monorepo and LICENSE.md doesn't call out this folder.

URL changed as requested.

GPL v3 license added to PCB folder as requested.
https://github.com/OneKeyHQ/firmware/tree/bixin_dev/docs/pcb/LICENSE.txt

@tannewt tannewt merged commit 9588c62 into pidcodes:master Mar 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants