Install updated valgrind using another source. #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soumith
approved these changes
Nov 2, 2018
facebook-github-bot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Nov 6, 2018
Summary: We updated valgrind version in our recent docker image. pietern/pytorch-dockerfiles#23 pytorch/ossci-job-dsl#31 Pull Request resolved: #13581 Reviewed By: goldsborough Differential Revision: D12936485 Pulled By: zrphercule fbshipit-source-id: 981532394b23e8d8ecfd6b2458ddf03710d5ac67
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found the valgrind in our docker image is too outdated which might cause some problems.
We here install newer valgrind from another source to pretend this.