Skip to content

Conversation

@zimulala
Copy link
Contributor

@zimulala zimulala commented Mar 5, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2024
@hfxsd hfxsd self-assigned this Mar 5, 2024
@hfxsd hfxsd added translation/doing This PR’s assignee is translating this PR. v8.0 This PR/issue applies to TiDB v8.0. and removed missing-translation-status This PR does not have translation status info. labels Mar 5, 2024
@zimulala zimulala requested a review from tangenta March 5, 2024 11:28
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 5, 2024

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
zimulala and others added 2 commits March 6, 2024 10:11
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
hfxsd and others added 3 commits March 6, 2024 10:15
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
Co-authored-by: Frank945946 <108602632+Frank945946@users.noreply.github.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd requested a review from Oreoxmt March 6, 2024 07:03
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 6, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 6, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-06 03:20:45.919606929 +0000 UTC m=+223672.941853316: ☑️ agreed by tangenta.
  • 2024-03-06 07:03:59.437550646 +0000 UTC m=+237066.459797034: ☑️ agreed by hfxsd.

zimulala and others added 3 commits March 7, 2024 16:53
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
Co-authored-by: Aolin <aolinz@outlook.com>
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit ce2042c into pingcap:master Mar 19, 2024
@zimulala zimulala deleted the zimuxia/default-expr branch March 19, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v8.0 This PR/issue applies to TiDB v8.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants