Skip to content

reference/best-practices: add optimistic transaction best practices #2079

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Dec 2, 2019
Merged

reference/best-practices: add optimistic transaction best practices #2079

merged 7 commits into from
Dec 2, 2019

Conversation

@anotherrachel
Copy link
Contributor

@anotherrachel anotherrachel commented Nov 27, 2019 •
edited
Loading

What is changed, added or deleted?

This PR added the Optimistic Transaction Best Practices to the Best Practice series.

What is the related PR or file link(s)?

N/A

Which version does your change affect?

dev
I'll update v2.1, v3.0 and v3.1 when these changes are approved.

@anotherrachel anotherrachel added DNM area/best-practices Adds or updates TiDB best practices. size/large Changes of a large size. labels Nov 27, 2019
@anotherrachel anotherrachel marked this pull request as ready for review November 27, 2019 09:04
dcalvin
dcalvin reviewed Nov 29, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments. Good work.

@dcalvin dcalvin requested a review from AndreMouche November 29, 2019 06:40
dcalvin
dcalvin approved these changes Nov 29, 2019
View reviewed changes
Copy link
Contributor

@dcalvin dcalvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please also apply to other versions

@anotherrachel anotherrachel force-pushed the optimistic-transaction branch from d3b0f58 to 440cc64 Compare December 2, 2019 08:34
@anotherrachel anotherrachel added translation/doing This PR’s assignee is translating this PR. v2.1 and removed DNM labels Dec 2, 2019
@anotherrachel
Copy link
Contributor Author

@AndreMouche PTAL, thanks~

AndreMouche
AndreMouche approved these changes Dec 2, 2019
View reviewed changes
Copy link
Contributor

@AndreMouche AndreMouche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@anotherrachel anotherrachel merged commit 97e7457 into pingcap:master Dec 2, 2019
@anotherrachel anotherrachel deleted the optimistic-transaction branch December 2, 2019 09:58
@anotherrachel anotherrachel mentioned this pull request Dec 9, 2019
Closed
@anotherrachel anotherrachel added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Dec 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AndreMouche AndreMouche AndreMouche approved these changes

+1 more reviewer

@dcalvin dcalvin dcalvin approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@anotherrachel anotherrachel

Labels

area/best-practices Adds or updates TiDB best practices. size/large Changes of a large size. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anotherrachel @AndreMouche @dcalvin