Skip to content

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Feb 4, 2020

What is changed, added or deleted?

Add user documentation for auto_random feature.

What is the related PR or file link(s)?

Which TiDB version(s) does your changes apply to?

  • All active versions: dev, v3.0, v2.1, v3.1
  • dev (the latest development version)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)
  • v3.1 (TiDB 3.1 versions)
  • v4.0 (TiDB 4.0 versions)
  • All active and inactive versions
  • N/A (not applicable)

Note: If your changes apply to multiple TiDB versions, make sure you update the documents in the corresponding version folders such as "dev", "v3.0", "v2.1" and "v3.1" in this PR.

  • Updated one version first. Will update other versions after I get two LGTMs.

@AilinKid
Copy link
Contributor

AilinKid commented Feb 4, 2020

should check the lint

@TomShawn TomShawn added dev translation/doing This PR’s assignee is translating this PR. v4.0 This PR/issue applies to TiDB v4.0. labels Feb 4, 2020
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133 bb7133 added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 6, 2020
@bb7133
Copy link
Member

bb7133 commented Feb 6, 2020

@tangenta Please notice that AUTO_RANDOM has been backported to 3.1.

@bb7133
Copy link
Member

bb7133 commented Feb 10, 2020

PTAL @TomShawn @kennytm @AilinKid @yikeke , thanks.

@TomShawn TomShawn self-assigned this Feb 10, 2020
@yikeke yikeke requested a review from TomShawn February 10, 2020 12:12
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The same for v3.1.

@tangenta tangenta force-pushed the autorand branch 2 times, most recently from 7b4dac1 to 4f8dd59 Compare February 17, 2020 07:31
@tangenta tangenta requested a review from TomShawn February 18, 2020 02:22
@yikeke
Copy link
Contributor

yikeke commented Feb 23, 2020

After this PR merges, sre-bot will automatically cherry-pick this PR to the release-3.1 branch (the needs-cherry-pick-xxx label will trigger the behavior). FYI. @tangenta @AilinKid @kennytm @bb7133 @djshow832

Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TomShawn TomShawn added the status/can-merge Indicates a PR has been approved by a committer. label Feb 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 24, 2020

/run-all-tests

@sre-bot sre-bot merged commit 5059c83 into pingcap:master Feb 24, 2020
@sre-bot
Copy link
Contributor

sre-bot commented Feb 24, 2020

cherry pick to release-3.1 failed

@TomShawn
Copy link
Contributor

/run-cherry-picker

@sre-bot
Copy link
Contributor

sre-bot commented Feb 24, 2020

cherry pick to failed

@sre-bot
Copy link
Contributor

sre-bot commented Feb 24, 2020

cherry pick to release-3.1 failed

@pingcap pingcap deleted a comment from sre-bot Feb 24, 2020
@pingcap pingcap deleted a comment from sre-bot Feb 24, 2020
@pingcap pingcap deleted a comment from sre-bot Feb 24, 2020
@pingcap pingcap deleted a comment from sre-bot Feb 24, 2020
@pingcap pingcap deleted a comment from sre-bot Feb 24, 2020
tangenta added a commit to tangenta/docs-cn that referenced this pull request Feb 24, 2020
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Feb 26, 2020
@yikeke yikeke removed v3.1 labels Mar 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. v4.0 This PR/issue applies to TiDB v4.0.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants