Skip to content

correct the content in auto-random.md #4246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 12, 2020
Merged

correct the content in auto-random.md #4246

merged 6 commits into from
Aug 12, 2020

Conversation

@tangenta
Copy link
Contributor

What is changed, added or deleted? (Required)

Some of the descriptions in auto-random.md are outdated. This PR correct the description.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

kissmydb
kissmydb approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@kissmydb kissmydb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 11, 2020
bb7133
bb7133 reviewed Aug 11, 2020
View reviewed changes
@TomShawn TomShawn self-assigned this Aug 12, 2020
@TomShawn TomShawn added needs-cherry-pick-4.0 size/small Changes of a small size. translation/doing This PR’s assignee is translating this PR. labels Aug 12, 2020
@TomShawn TomShawn self-requested a review August 12, 2020 03:54
AilinKid
AilinKid reviewed Aug 12, 2020
View reviewed changes
Copy link
Contributor

@AilinKid AilinKid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@AilinKid,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

TomShawn
TomShawn reviewed Aug 12, 2020
View reviewed changes
TomShawn
TomShawn reviewed Aug 12, 2020
View reviewed changes
TomShawn
TomShawn approved these changes Aug 12, 2020
View reviewed changes
Copy link
Contributor

@TomShawn TomShawn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot ti-srebot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Aug 12, 2020
@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 12, 2020
@TomShawn TomShawn merged commit 8c1074e into pingcap:master Aug 12, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 12, 2020
@ti-srebot
cherry pick pingcap#4246 to release-4.0
12a79c6 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 12, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4254

TomShawn pushed a commit that referenced this pull request Aug 12, 2020
@ti-srebot @tangenta
cherry pick #4246 to release-4.0 (#4254)
2e4c633 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: tangenta <tangenta@126.com>
@TomShawn TomShawn mentioned this pull request Aug 17, 2020
Merged
9 tasks
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR’s assignee is translating this PR. labels Aug 17, 2020
@ti-srebot ti-srebot mentioned this pull request Aug 24, 2020
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bb7133 bb7133 bb7133 left review comments

@AilinKid AilinKid AilinKid left review comments

@ti-srebot ti-srebot ti-srebot approved these changes

+2 more reviewers

@kissmydb kissmydb kissmydb approved these changes

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@TomShawn TomShawn

Labels

require-LGT1 Indicates that the PR requires an LGTM. size/small Changes of a small size. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tangenta @ti-srebot @bb7133 @AilinKid @kissmydb @TomShawn