Skip to content

update pd-recover docs #4261

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Aug 31, 2020
Merged

update pd-recover docs #4261

merged 8 commits into from
Aug 31, 2020

Conversation

@ran-huang
Copy link
Contributor

Signed-off-by: Ran huangran@pingcap.com

What is changed, added or deleted? (Required)

Update pd-recover docs.

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@ran-huang
update pd-recover docs
d7ccaf7 
Signed-off-by: Ran <huangran@pingcap.com>
@ran-huang ran-huang added needs-cherry-pick-4.0 translation/from-docs This PR is translated from a PR in pingcap/docs. labels Aug 13, 2020
@ran-huang ran-huang requested review from TomShawn and rleungx August 13, 2020 04:07
@ran-huang ran-huang added the status/PTAL This PR is ready for reviewing. label Aug 13, 2020
TomShawn
TomShawn reviewed Aug 13, 2020
View reviewed changes
@TomShawn TomShawn added status/require-change Needs the author to address comments. and removed status/PTAL This PR is ready for reviewing. labels Aug 14, 2020
@ran-huang @TomShawn
Apply suggestions from code review
cef1689 
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn
Copy link
Contributor

LGTM
@rleungx PTAL

@ti-srebot
Copy link
Contributor

@TomShawn, @rleungx, PTAL.

@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

@ran-huang ran-huang added status/PTAL This PR is ready for reviewing. and removed status/require-change Needs the author to address comments. labels Aug 17, 2020
@ti-srebot
Copy link
Contributor

@TomShawn, @rleungx, PTAL.

@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

@ti-srebot
Copy link
Contributor

@TomShawn, @rleungx, PTAL.

@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

@ti-srebot
Copy link
Contributor

No updates for a long time, close PR.

@rleungx rleungx mentioned this pull request Aug 21, 2020
Closed
9 tasks
@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

@ran-huang
Copy link
Contributor Author

@rleungx @nolouch PTAL~ Thanks!

@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

@ran-huang ran-huang requested a review from nolouch August 26, 2020 04:03
@ti-srebot
Copy link
Contributor

@ran-huang, please update your pull request.

rleungx
rleungx reviewed Aug 31, 2020
View reviewed changes
@TomShawn @rleungx
Update pd-recover.md
8d0848e 
Co-authored-by: Ryan Leung <rleungx@gmail.com>
rleungx
rleungx approved these changes Aug 31, 2020
View reviewed changes
Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-srebot
Copy link
Contributor

@rleungx,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn requested a review from disksing August 31, 2020 07:54
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Aug 31, 2020
@ti-srebot
Copy link
Contributor

@disksing,Thanks for your review. However, LGTM is restricted to Reviewers or higher roles.See the corresponding SIG page for more information. Related SIGs: docs(slack).

@TomShawn TomShawn added require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. labels Aug 31, 2020
@ti-srebot
Copy link
Contributor

/run-all-tests

@ti-srebot ti-srebot merged commit 5dc1394 into pingcap:master Aug 31, 2020
ti-srebot pushed a commit to ti-srebot/docs-cn that referenced this pull request Aug 31, 2020
@ran-huang @ti-srebot
cherry pick pingcap#4261 to release-4.0
83b4181 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 31, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4389

@ran-huang ran-huang deleted the pd_recover branch August 31, 2020 09:31
ti-srebot added a commit that referenced this pull request Aug 31, 2020
@ti-srebot @ran-huang
update pd-recover docs (#4261) (#4389)
69b30cb 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@disksing disksing disksing approved these changes

@rleungx rleungx rleungx approved these changes

@nolouch nolouch Awaiting requested review from nolouch

+1 more reviewer

@TomShawn TomShawn TomShawn approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

require-LGT1 Indicates that the PR requires an LGTM. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs This PR is translated from a PR in pingcap/docs.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ran-huang @TomShawn @ti-srebot @disksing @rleungx