Skip to content

Conversation

@xuechunL
Copy link
Contributor

@xuechunL xuechunL commented Apr 9, 2018

add the conditional branches for formal and preview pdf.
PTAL @gaohailang @lilin90

Copy link

@sivagao sivagao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems good.
next time, maybe mv modify /etc/hosts outside the conditional process handle, which is duplicated

@xuechunL
Copy link
Contributor Author

xuechunL commented Apr 9, 2018

PTAL @gaohailang

Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xuechunL xuechunL merged commit 36255b0 into master Apr 10, 2018
@tiancaiamao tiancaiamao deleted the xuechun/polish-ci-pdf-generating branch April 16, 2018 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants