Skip to content

Conversation

@lilin90
Copy link
Member

@lilin90 lilin90 commented Sep 20, 2018

Copy link
Contributor

@CaitinChen CaitinChen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

+ MySQL 5.7 中使用 `latin1`(MySQL 8.0 中使用 `UTF-8`)
+ TiDB 使用 `utf8mb4`
+ TiDB 中为 `utf8`,相当于 MySQL `utf8mb4`
+ MySQL 5.7 中为 `latin1`,但在 MySQL 8.0 中更新为 `utf8mb4`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/更新/修改
这个算 change 了,而不是 update。update 一般指跟之前兼容的行为。

@lilin90
Copy link
Member Author

lilin90 commented Sep 21, 2018

@tiancaiamao PTAL again. Thanks!

@tiancaiamao
Copy link
Contributor

LGTM

@lilin90 lilin90 merged commit c258747 into pingcap:master Sep 21, 2018
@lilin90 lilin90 deleted the mysql-compat-update branch September 21, 2018 03:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants