Skip to content

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Nov 18, 2022

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v6.5 (TiDB 6.5 versions)
  • v6.4 (TiDB 6.4 versions)
  • v6.3 (TiDB 6.3 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/bugfix This PR fixes a bug. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-6.0 needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. labels Nov 18, 2022
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 18, 2022

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 18, 2022

/status LGT1

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 18, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 18, 2022

/verify

@Oreoxmt Oreoxmt requested a review from shichun-0415 November 18, 2022 03:58
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Nov 18, 2022
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 18, 2022

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 0ba3745

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Nov 18, 2022
@ti-chi-bot ti-chi-bot merged commit a7ef9f3 into pingcap:master Nov 18, 2022
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11363.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11364.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11365.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11366.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11367.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 18, 2022
15 tasks
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #11368.

ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
ti-chi-bot added a commit that referenced this pull request Nov 18, 2022
@Oreoxmt Oreoxmt deleted the translate/docs-cn-12048 branch February 14, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/deploy-upgrade-maintain Indicates that the Issue or PR belongs to the area of deployment, upgrade, and maintenance. needs-cherry-pick-release-5.4 Should cherry pick this PR to release-5.4 branch. needs-cherry-pick-release-6.1 Should cherry pick this PR to release-6.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/bugfix This PR fixes a bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants