Skip to content

Conversation

@lilyjazz
Copy link
Member

@lilyjazz lilyjazz commented May 31, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.2 (TiDB 7.2 versions)
  • v7.1 (TiDB 7.1 versions)
  • v7.0 (TiDB 7.0 versions)
  • v6.6 (TiDB 6.6 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link

ti-chi-bot bot commented May 31, 2023

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 31, 2023
@Oreoxmt Oreoxmt added translation/no-need No need to translate this PR. area/tidb-cloud This PR relates to the area of TiDB Cloud. labels Jun 1, 2023
@Oreoxmt Oreoxmt self-assigned this Jun 1, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Jun 1, 2023
@Oreoxmt Oreoxmt added missing-translation-status This PR does not have translation status info. for-cloud-release This PR is related to TiDB Cloud release. and removed missing-translation-status This PR does not have translation status info. labels Jun 1, 2023
@Oreoxmt Oreoxmt added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 5, 2023
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2023
@ti-chi-bot ti-chi-bot bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jun 5, 2023
@Oreoxmt Oreoxmt requested a review from hfxsd June 5, 2023 10:44
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

@shhdgit: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot removed the approved label Jun 6, 2023
Oreoxmt added 2 commits June 6, 2023 14:35
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: Grace Cai <qqzczy@126.com>
@Oreoxmt Oreoxmt requested review from Oreoxmt, hfxsd and qiancai June 6, 2023 08:18
@Oreoxmt Oreoxmt closed this Jun 6, 2023
@Oreoxmt Oreoxmt reopened this Jun 6, 2023
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jun 6, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-06-05 11:23:41.557246539 +0000 UTC m=+261007.830219335: ☑️ agreed by hfxsd.
  • 2023-06-06 08:39:18.641003314 +0000 UTC m=+337544.913976101: ☑️ agreed by Oreoxmt.

@ti-chi-bot ti-chi-bot bot added the approved label Jun 6, 2023
@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Jun 6, 2023

Copy link
Collaborator

@qiancai qiancai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jun 6, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt, qiancai, shhdgit

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Oreoxmt Oreoxmt removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 6, 2023
@ti-chi-bot ti-chi-bot bot merged commit 0cf416b into pingcap:release-6.5 Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tidb-cloud This PR relates to the area of TiDB Cloud. for-cloud-release This PR is related to TiDB Cloud release. lgtm size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants