Skip to content

fix the operator info #15291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 9, 2023
Merged

fix the operator info #15291

merged 3 commits into from
Nov 9, 2023

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Nov 8, 2023 •
edited
Loading

What is changed, added or deleted? (Required)

Fix the operator IDs to match the explain results

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2023
@qiancai qiancai added type/bugfix This PR fixes a bug. translation/doing This PR's assignee is translating this PR. labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Nov 8, 2023
@qiancai qiancai mentioned this pull request Nov 8, 2023
Merged
16 tasks
@qiancai qiancai added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 labels Nov 8, 2023
@qiancai qiancai requested a review from time-and-fate November 8, 2023 07:27
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2023

@time-and-fate: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

qiancai
qiancai commented Nov 8, 2023
View reviewed changes
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Nov 8, 2023
@Oreoxmt Oreoxmt self-requested a review November 8, 2023 08:07
time-and-fate
time-and-fate reviewed Nov 8, 2023
View reviewed changes
@qiancai @time-and-fate
Update explain-subqueries.md
b453614 
Co-authored-by: Zhou Kunqin <25057648+time-and-fate@users.noreply.github.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 8, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-08 08:11:23.540919918 +0000 UTC m=+3631881.128030063: ☑️ agreed by Oreoxmt.

@qiancai qiancai added the lgtm label Nov 8, 2023
@qiancai
Copy link
Collaborator Author

qiancai commented Nov 8, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 8, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 8, 2023
@qiancai qiancai removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
@qiancai qiancai added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed approved lgtm labels Nov 8, 2023
@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Nov 8, 2023
@qiancai qiancai added ONCALL Relates to documentation oncall. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Nov 8, 2023
This was referenced Nov 8, 2023
Merged
Merged
Merged
Merged
@qiancai qiancai added the lgtm label Nov 9, 2023
@ti-chi-bot ti-chi-bot bot merged commit 2f525fd into pingcap:master Nov 9, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #15302.

This was referenced Nov 9, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #15303.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2023

In response to a cherrypick label: new pull request created to branch release-7.3: #15304.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 9, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 9, 2023

In response to a cherrypick label: new pull request created to branch release-7.4: #15305.

Oreoxmt pushed a commit to Oreoxmt/docs that referenced this pull request Nov 13, 2023
@qiancai @Oreoxmt
fix the operator info (pingcap#15291)
1d4ab7c
ti-chi-bot bot pushed a commit that referenced this pull request Nov 17, 2023
@ti-chi-bot
fix the operator info (#15291) (#15304)
2de67ca
ti-chi-bot bot pushed a commit that referenced this pull request Nov 17, 2023
@ti-chi-bot
fix the operator info (#15291) (#15303)
4e5af15
ti-chi-bot bot pushed a commit that referenced this pull request Nov 17, 2023
@ti-chi-bot
fix the operator info (#15291) (#15305)
0469e34
ti-chi-bot bot pushed a commit that referenced this pull request Nov 17, 2023
@ti-chi-bot
fix the operator info (#15291) (#15302)
acce6fc
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@time-and-fate time-and-fate time-and-fate approved these changes

@Oreoxmt Oreoxmt Oreoxmt approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. type/bugfix This PR fixes a bug.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@qiancai @ti-chi-bot @time-and-fate @Oreoxmt