Skip to content

ticdc: update best practices #15494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 28, 2023
Merged

ticdc: update best practices #15494

merged 2 commits into from
Nov 28, 2023

Conversation

@Oreoxmt
Copy link
Collaborator

@Oreoxmt Oreoxmt commented Nov 28, 2023

What is changed, added or deleted? (Required)

Update the best practices for TiCDC

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@Oreoxmt Oreoxmt added type/enhancement The issue or PR belongs to an enhancement. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. ONCALL Relates to documentation oncall. area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. labels Nov 28, 2023
@Oreoxmt Oreoxmt requested a review from lilin90 November 28, 2023 02:32
@Oreoxmt Oreoxmt self-assigned this Nov 28, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 28, 2023
@Oreoxmt
ticdc: update best practices
92801ee 
Signed-off-by: Aolin <aolin.zhang@pingcap.com>
@Oreoxmt Oreoxmt force-pushed the translate/docs-cn-15516 branch from 9e4ab1e to 92801ee Compare November 28, 2023 03:00
lilin90
lilin90 reviewed Nov 28, 2023
View reviewed changes
@Oreoxmt @lilin90
refine wording
2b43083 
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@Oreoxmt Oreoxmt requested a review from lilin90 November 28, 2023 06:23
lilin90
lilin90 approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 28, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-11-28 06:23:58.776379165 +0000 UTC m=+903867.441605353: ☑️ agreed by lilin90.

@lilin90 lilin90 added the lgtm label Nov 28, 2023
@Oreoxmt
Copy link
Collaborator Author

Oreoxmt commented Nov 28, 2023

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Oreoxmt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 28, 2023
@ti-chi-bot ti-chi-bot bot merged commit 321c013 into pingcap:master Nov 28, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #15495.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
16 tasks
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 28, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#15494
8464de3 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2023

In response to a cherrypick label: new pull request created to branch release-7.3: #15496.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2023

In response to a cherrypick label: new pull request created to branch release-7.4: #15497.

ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Nov 28, 2023
@Oreoxmt @ti-chi-bot
This is an automated cherry-pick of pingcap#15494
878c2fe 
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2023

In response to a cherrypick label: new pull request created to branch release-7.5: #15498.

@ti-chi-bot ti-chi-bot mentioned this pull request Nov 28, 2023
Merged
16 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Nov 28, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #15499.

@Oreoxmt Oreoxmt deleted the translate/docs-cn-15516 branch November 28, 2023 06:48
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@ti-chi-bot
ticdc: update best practices (#15494) (#15495)
b2899e5
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@ti-chi-bot
ticdc: update best practices (#15494) (#15497)
58bc187
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@ti-chi-bot
ticdc: update best practices (#15494) (#15498)
451d2dc
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@ti-chi-bot
ticdc: update best practices (#15494) (#15496)
5a4aceb
ti-chi-bot bot pushed a commit that referenced this pull request Nov 28, 2023
@ti-chi-bot
ticdc: update best practices (#15494) (#15499)
1ed1e31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lilin90 lilin90 lilin90 approved these changes

@nongfushanquan nongfushanquan Awaiting requested review from nongfushanquan

Assignees

@Oreoxmt Oreoxmt

Labels

approved area/ticdc Indicates that the Issue or PR belongs to the area of TiCDC. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/enhancement The issue or PR belongs to an enhancement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Oreoxmt @ti-chi-bot @lilin90