Skip to content

update the variable scope #15655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 11, 2023
Merged

update the variable scope #15655

merged 3 commits into from
Dec 11, 2023

Conversation

@ran-huang
Copy link
Contributor

@ran-huang ran-huang commented Dec 11, 2023

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.3 (TiDB 7.3 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ran-huang ran-huang added needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.3 needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. labels Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Dec 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[LGTM Timeline notifier]

Timeline:

  • 2023-12-11 10:04:05.448176235 +0000 UTC m=+264136.485403162: ☑️ agreed by qiancai.

@ran-huang
Copy link
Contributor Author

ran-huang commented Dec 11, 2023

/approve

@ran-huang ran-huang added the lgtm label Dec 11, 2023
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 11, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ran-huang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 11, 2023
@ti-chi-bot ti-chi-bot bot merged commit 3168b8f into pingcap:master Dec 11, 2023
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2023

In response to a cherrypick label: new pull request created to branch release-6.5: #15657.

This was referenced Dec 11, 2023
Merged
Merged
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2023

In response to a cherrypick label: new pull request created to branch release-7.1: #15658.

@ran-huang ran-huang deleted the 1211oncall/variable_scope-15655 branch December 11, 2023 10:06
@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2023

In response to a cherrypick label: new pull request created to branch release-7.3: #15659.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2023
Merged
18 tasks
@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2023

In response to a cherrypick label: new pull request created to branch release-7.4: #15660.

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Dec 11, 2023

In response to a cherrypick label: new pull request created to branch release-7.5: #15661.

@ti-chi-bot ti-chi-bot mentioned this pull request Dec 11, 2023
Merged
18 tasks
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@ti-chi-bot
update the variable scope (#15655) (#15660)
9a1cd13
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@ti-chi-bot
update the variable scope (#15655) (#15657)
c499ae2
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@ti-chi-bot
update the variable scope (#15655) (#15659)
0eb097d
ran-huang added a commit that referenced this pull request Dec 11, 2023
@ti-chi-bot @ran-huang
update the variable scope (#15655) (#15661)
8c21aa2 
* Add temp.md

* Delete temp.md

* add translation

---------

Co-authored-by: Ran <huangran.alex@gmail.com>
ti-chi-bot bot pushed a commit that referenced this pull request Dec 11, 2023
@ti-chi-bot
update the variable scope (#15655) (#15658)
90bf0e0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@qiancai qiancai qiancai approved these changes

Assignees

No one assigned

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-6.5 Should cherry pick this PR to release-6.5 branch. needs-cherry-pick-release-7.1 Should cherry pick this PR to release-7.1 branch. needs-cherry-pick-release-7.5 Should cherry pick this PR to release-7.5 branch. ONCALL Relates to documentation oncall. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ran-huang @ti-chi-bot @qiancai