Skip to content

Conversation

@cfzjywxk
Copy link
Contributor

@cfzjywxk cfzjywxk commented Mar 8, 2024

First-time contributors' checklist

What is changed, added or deleted? (Required)

Related to pingcap/docs-cn#16757

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.4 (TiDB 7.4 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 8, 2024
@cfzjywxk cfzjywxk requested review from Oreoxmt and lilin90 March 8, 2024 03:25
@lilin90 lilin90 requested review from hfxsd and removed request for lilin90 March 8, 2024 03:50
@lilin90 lilin90 changed the title Update system-variables.md *: add tidb_low_resolution_tso_update_interval Mar 8, 2024
@lilin90 lilin90 added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Mar 8, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Mar 8, 2024
@lilin90 lilin90 added missing-translation-status This PR does not have translation status info. v8.0 and removed missing-translation-status This PR does not have translation status info. labels Mar 8, 2024
@hfxsd hfxsd requested a review from joey-yez March 8, 2024 05:19
@hfxsd hfxsd added the type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. label Mar 8, 2024
@hfxsd hfxsd added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 11, 2024
cfzjywxk and others added 2 commits March 14, 2024 14:34
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@hfxsd hfxsd removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 14, 2024
Co-authored-by: Aolin <aolin.zhang@pingcap.com>
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Mar 14, 2024
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Mar 14, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-03-14 08:24:41.0828768 +0000 UTC m=+933108.105123198: ☑️ agreed by hfxsd.
  • 2024-03-14 09:14:39.731671611 +0000 UTC m=+936106.753917996: ☑️ agreed by Oreoxmt.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 14, 2024

@joey-yez: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@hfxsd hfxsd changed the title *: add tidb_low_resolution_tso_update_interval *: add tidb_low_resolution_tso_update_interval Mar 19, 2024
@hfxsd
Copy link
Collaborator

hfxsd commented Mar 19, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Mar 19, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Mar 19, 2024
@ti-chi-bot ti-chi-bot bot merged commit efca22a into master Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm size/S Denotes a PR that changes 10-29 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. type/compatibility-or-feature-change This PR involves compatibility changes or feature behavior changes. v8.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants