Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Oct 10, 2024

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v8.2 (TiDB 8.2 versions)
  • v8.1 (TiDB 8.1 versions)
  • v8.0 (TiDB 8.0 versions)
  • v7.6 (TiDB 7.6 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)
  • v5.3 (TiDB 5.3 versions)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Oct 10, 2024
@dveeden dveeden requested review from mjonss and qiancai October 10, 2024 07:27
Copy link
Contributor

@mjonss mjonss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with some suggestions

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 21, 2024

@mjonss: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

LGTM with some suggestions

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dveeden
Copy link
Contributor Author

dveeden commented Oct 23, 2024

@mjonss should we mention weird things like the right/ zones (e.g. right/Universal) and posix/ (e.g. posix/Chile/EasterIsland) ? Or should we remove support for them maybe?

TiDB

mysql-8.0.11-TiDB-v8.4.0-alpha-445-g6eed1cd7bd> SET time_zone = 'posix/Chile/EasterIsland';
Query OK, 0 rows affected (0.00 sec)

mysql-8.0.11-TiDB-v8.4.0-alpha-445-g6eed1cd7bd> SET time_zone = 'right/Universal';
Query OK, 0 rows affected (0.00 sec)

MySQL

mysql-9.1.0> SET time_zone = 'posix/Chile/EasterIsland';
ERROR 1298 (HY000): Unknown or incorrect time zone: 'posix/Chile/EasterIsland'
mysql-9.1.0> SET time_zone = 'right/Universal';
ERROR 1298 (HY000): Unknown or incorrect time zone: 'right/Universal'

@mjonss
Copy link
Contributor

mjonss commented Oct 29, 2024

@mjonss should we mention weird things like the right/ zones (e.g. right/Universal) and posix/ (e.g. posix/Chile/EasterIsland) ? Or should we remove support for them maybe?
...

I think we don't need to mention it, since it is platform/OS/installation dependent, I think we can ignore it and just keep what golang implements. As long as we are MySQL compatible too :)

@qiancai qiancai self-assigned this Oct 31, 2024
@qiancai qiancai added the translation/doing This PR's assignee is translating this PR. label Oct 31, 2024
@ti-chi-bot ti-chi-bot bot removed the missing-translation-status This PR does not have translation status info. label Oct 31, 2024
dveeden and others added 2 commits November 6, 2024 10:55
@ti-chi-bot ti-chi-bot bot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2024
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 11, 2024
@dveeden dveeden requested review from Oreoxmt and hfxsd November 13, 2024 06:11
@qiancai qiancai added the needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. label Dec 3, 2024
@qiancai qiancai mentioned this pull request Dec 4, 2024
17 tasks
@qiancai qiancai added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Dec 4, 2024
@qiancai qiancai removed the request for review from Oreoxmt December 4, 2024 09:31
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Dec 4, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 4, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-11-11 09:06:36.952844613 +0000 UTC m=+260759.143713611: ☑️ agreed by qiancai.
  • 2024-12-04 14:50:43.216884669 +0000 UTC m=+1252830.836539180: ☑️ agreed by hfxsd.

Co-authored-by: xixirangrang <hfxsd@hotmail.com>
@qiancai
Copy link
Collaborator

qiancai commented Dec 5, 2024

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Dec 5, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Dec 5, 2024
@ti-chi-bot ti-chi-bot bot merged commit b13021b into pingcap:master Dec 5, 2024
9 checks passed
ti-chi-bot pushed a commit to ti-chi-bot/docs that referenced this pull request Dec 5, 2024
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #19587.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants