Skip to content

Conversation

@dveeden
Copy link
Contributor

@dveeden dveeden commented Jan 21, 2025

What is changed, added or deleted? (Required)

  • The current advise doesn't always make a reboot-safe change (it only changes the running configuration).

See also:

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.4 (TiDB 8.4 versions)
  • v8.3 (TiDB 8.3 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@dveeden dveeden requested review from Oreoxmt, bb7133 and qiancai January 21, 2025 07:01
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 21, 2025
@dveeden dveeden added the area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. label Jan 21, 2025
@dveeden dveeden requested a review from breezewish January 21, 2025 10:55
@hfxsd hfxsd mentioned this pull request Jan 23, 2025
16 tasks
@hfxsd hfxsd added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed missing-translation-status This PR does not have translation status info. labels Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jan 23, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-01-23 02:05:21.394699773 +0000 UTC m=+319248.725619177: ☑️ agreed by hfxsd.
  • 2025-01-23 06:31:00.575455616 +0000 UTC m=+335187.906375019: ☑️ agreed by breezewish.

@hfxsd hfxsd self-assigned this Jan 23, 2025
@hfxsd
Copy link
Collaborator

hfxsd commented Jan 23, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Jan 23, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Jan 23, 2025
@ti-chi-bot ti-chi-bot bot merged commit 2db7029 into pingcap:master Jan 23, 2025
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #20139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved area/tiup Indicates that the Issue or PR belongs to the area of the TiUP tool. lgtm needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants