Skip to content

i18n: fix invalid SVG markup in release-notes-2023.md #22012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 5, 2025
Merged

i18n: fix invalid SVG markup in release-notes-2023.md #22012

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tidb-cloud/release-notes-2023.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -703,7 +703,7 @@

**Getting Started** 页面提供交互式教程、基础指南和实用链接。通过交互式教程可体验 TiDB Cloud 功能和 HTAP 能力，内置 Steam 游戏和 S&P 500 行业数据集。

访问方法：在 [TiDB Cloud 控制台](https://tidbcloud.com/) 左侧导航栏点击 <svg ...></svg> **Getting Started**，或点击 **?** > **Interactive Tutorials**。
访问方法：在 [TiDB Cloud 控制台](https://tidbcloud.com/) 左侧导航栏点击 <svg width="20" height="20" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M12 14.9998L9 11.9998M12 14.9998C13.3968 14.4685 14.7369 13.7985 16 12.9998M12 14.9998V19.9998C12 19.9998 15.03 19.4498 16 17.9998C17.08 16.3798 16 12.9998 16 12.9998M9 11.9998C9.53214 10.6192 10.2022 9.29582 11 8.04976C12.1652 6.18675 13.7876 4.65281 15.713 3.59385C17.6384 2.53489 19.8027 1.98613 22 1.99976C22 4.71976 21.22 9.49976 16 12.9998M9 11.9998H4C4 11.9998 4.55 8.96976 6 7.99976C7.62 6.91976 11 7.99976 11 7.99976M4.5 16.4998C3 17.7598 2.5 21.4998 2.5 21.4998C2.5 21.4998 6.24 20.9998 7.5 19.4998C8.21 18.6598 8.2 17.3698 7.41 16.5898C7.02131 16.2188 6.50929 16.0044 5.97223 15.9878C5.43516 15.9712 4.91088 16.1535 4.5 16.4998Z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"></path></svg> **Getting Started**，或点击 **?** > **Interactive Tutorials**。

Check failure on line 706 in tidb-cloud/release-notes-2023.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[PingCAP.ZhPunctuation] Don't use Chinese punctuation (。) in English text.

Raw Output:
{"message": "[PingCAP.ZhPunctuation] Don't use Chinese punctuation (。) in English text.", "location": {"path": "tidb-cloud/release-notes-2023.md", "range": {"start": {"line": 706, "column": 963}}}, "severity": "ERROR"}

Check failure on line 706 in tidb-cloud/release-notes-2023.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[PingCAP.ZhPunctuation] Don't use Chinese punctuation (，) in English text.

Raw Output:
{"message": "[PingCAP.ZhPunctuation] Don't use Chinese punctuation (，) in English text.", "location": {"path": "tidb-cloud/release-notes-2023.md", "range": {"start": {"line": 706, "column": 925}}}, "severity": "ERROR"}

Check failure on line 706 in tidb-cloud/release-notes-2023.md

View workflow job for this annotation

GitHub Actions / vale 

[vale] reported by reviewdog 🐶
[PingCAP.ZhPunctuation] Don't use Chinese punctuation (：) in English text.

Raw Output:
{"message": "[PingCAP.ZhPunctuation] Don't use Chinese punctuation (：) in English text.", "location": {"path": "tidb-cloud/release-notes-2023.md", "range": {"start": {"line": 706, "column": 9}}}, "severity": "ERROR"}
Copy link

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

While the inline SVG is correct, it makes the Markdown source code harder to read and maintain due to its length, which impacts readability.1 I've noticed that other icons in this file are handled by an <MDSvgIcon> component (e.g., on line 315). For consistency and better maintainability, consider abstracting this SVG into a similar component if possible. This would make the Markdown source cleaner, for example: <MDSvgIcon name="getting-started" />.

Style Guide References

Footnotes

  1. The style guide emphasizes clarity and readability. Using a long inline SVG reduces the readability of the Markdown source. Abstracting it into a component would improve this. ↩

Copy link

@gemini-code-assist gemini-code-assist bot Nov 5, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

low

For better readability and a slightly smaller file size, you could round the coordinates in the SVG path data to two decimal places. This shouldn't affect the rendering of this small icon.

Suggested change
访问方法：在 [TiDB Cloud 控制台](https://tidbcloud.com/) 左侧导航栏点击 <svg width="20" height="20" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M12 14.9998L9 11.9998M12 14.9998C13.3968 14.4685 14.7369 13.7985 16 12.9998M12 14.9998V19.9998C12 19.9998 15.03 19.4498 16 17.9998C17.08 16.3798 16 12.9998 16 12.9998M9 11.9998C9.53214 10.6192 10.2022 9.29582 11 8.04976C12.1652 6.18675 13.7876 4.65281 15.713 3.59385C17.6384 2.53489 19.8027 1.98613 22 1.99976C22 4.71976 21.22 9.49976 16 12.9998M9 11.9998H4C4 11.9998 4.55 8.96976 6 7.99976C7.62 6.91976 11 7.99976 11 7.99976M4.5 16.4998C3 17.7598 2.5 21.4998 2.5 21.4998C2.5 21.4998 6.24 20.9998 7.5 19.4998C8.21 18.6598 8.2 17.3698 7.41 16.5898C7.02131 16.2188 6.50929 16.0044 5.97223 15.9878C5.43516 15.9712 4.91088 16.1535 4.5 16.4998Z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"></path></svg> **Getting Started**，或点击 **?** > **Interactive Tutorials**。
访问方法：在 [TiDB Cloud 控制台](https://tidbcloud.com/) 左侧导航栏点击 <svg width="20" height="20" viewBox="0 0 24 24" fill="none" xmlns="http://www.w3.org/2000/svg"><path d="M12 15L9 12M12 15C13.4 14.47 14.74 13.8 16 13M12 15V20C12 20 15.03 19.45 16 18C17.08 16.38 16 13 16 13M9 12C9.53 10.62 10.2 9.3 11 8.05C12.17 6.19 13.79 4.65 15.71 3.59C17.64 2.53 19.8 1.99 22 2C22 4.72 21.22 9.5 16 13M9 12H4C4 12 4.55 8.97 6 8C7.62 6.92 11 8 11 8M4.5 16.5C3 17.76 2.5 21.5 2.5 21.5C2.5 21.5 6.24 21 7.5 19.5C8.21 18.66 8.2 17.37 7.41 16.59C7.02 16.22 6.51 16 5.97 15.99C5.44 15.97 4.91 16.15 4.5 16.5Z" stroke="currentColor" stroke-width="2" stroke-linecap="round" stroke-linejoin="round"></path></svg> **Getting Started**，或点击 **?** > **Interactive Tutorials**。


## 2023 年 3 月 29 日

Expand Down
Loading