Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Nov 11, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Nov 11, 2025
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Nov 11, 2025
@hfxsd hfxsd added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. and removed contribution This PR is from a community contributor. labels Nov 11, 2025
@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2025
@hfxsd hfxsd added v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the documentation around character set support in TiDB by introducing comprehensive details for the GB18030 character set. It provides a new dedicated guide for GB18030, integrates its information into existing character set and collation overviews, and clarifies compatibility considerations for various TiDB tools and components. The changes aim to provide users with a clearer understanding of GB18030's behavior and limitations within the TiDB ecosystem.

Highlights

  • GB18030 Character Set Documentation: Introduced a new dedicated document (character-set-gb18030.md) detailing TiDB's support for the GB18030-2022 character set, including its compatibility with MySQL and various TiDB components.
  • Updated Character Set Overviews: Modified character-set-and-collation.md to include GB18030 in the list of supported character sets and collations, and updated information-schema-character-sets.md and migrate-from-mariadb.md with GB18030 details.
  • Compatibility Clarifications: Added specific compatibility notes for GB18030 in backup/restore (br/backup-and-restore-overview.md), data migration (dm/dm-overview.md), and general MySQL compatibility (mysql-compatibility.md).
  • GBK Documentation Refinement: Updated character-set-gbk.md to clarify the default collation behavior and examples when the new collation framework is enabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@hfxsd hfxsd requested a review from Frank945946 November 11, 2025 03:02
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the GB18030 character set. The changes are mostly good, but I've provided several suggestions to improve clarity, consistency, and correctness across the new and updated documentation files. Key suggestions include making summaries more concise, fixing typos, clarifying misleading descriptions, and restructuring a confusing section in one of the documents.

@ti-chi-bot ti-chi-bot bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 11, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2025

@Frank945946: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Contributor

@fzzf678 fzzf678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

Comment on lines 25 to 27
```

```
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed according https://github.com/pingcap/docs-cn/pull/18662/files#diff-d814c7fc5fe39bf56a3839975e44bdeba3e92e16e8f6a01afa5c1cc7f685def1L27-L29, or remove the Chinese version modification, anyway, they should be unified

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 11, 2025

@fzzf678: adding LGTM is restricted to approvers and reviewers in OWNERS files.

In response to this:

Rest LGTM

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@hfxsd hfxsd changed the title tidb: add description about GB18030 tidb: add GB18030 doc Nov 11, 2025
@ti-chi-bot ti-chi-bot bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 11, 2025
@hfxsd hfxsd requested a review from lilin90 November 11, 2025 11:24
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 07:56:52.993782766 +0000 UTC m=+1380062.436812635: ☑️ agreed by lilin90.

@hfxsd hfxsd added the lgtm label Nov 18, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Nov 18, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 18, 2025
Co-authored-by: Lilian Lee <lilin@pingcap.com>
@lilin90
Copy link
Member

lilin90 commented Nov 18, 2025

/hold

@ti-chi-bot ti-chi-bot bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
hfxsd and others added 5 commits November 18, 2025 16:13
Co-authored-by: Lilian Lee <lilin@pingcap.com>
Linked the GB18030 character set documentation in the table of contents, character set overview, and MySQL compatibility pages. Updated the GB18030 documentation to indicate its introduction in v9.0.0.
Changed the link for `new_collations_enabled_on_first_bootstrap` from a relative path to the official TiDB documentation URL for improved clarity and accessibility.
@lilin90
Copy link
Member

lilin90 commented Nov 18, 2025

/unhold

@ti-chi-bot ti-chi-bot bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit d4d9430 into pingcap:master Nov 18, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. v9.0-beta.2 This PR/issue applies to TiDB v9.0-beta.2.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants