Skip to content

Conversation

@qiancai
Copy link
Collaborator

@qiancai qiancai commented Nov 18, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Added TiDB v8.5.4 compatibility changes link in the upgrade guide and updated the TiDB version in variables.json to 8.5.4.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@qiancai qiancai added the translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. label Nov 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @qiancai, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to update the documentation to reflect the release of TiDB v8.5.4. It includes bumping the version number in relevant configuration files and adding a link to the compatibility changes in the upgrade guide. Please note that the provided patch only shows the addition of a test file, which may not fully reflect the described changes.

Highlights

  • Version Bump: The latest TiDB version has been updated to v8.5.4.
  • Documentation Update: A compatibility changes link for TiDB v8.5.4 has been added to the upgrade guide.
  • Configuration Update: The TiDB version in variables.json has been updated to 8.5.4.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@ti-chi-bot ti-chi-bot bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 18, 2025
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a new file temp.md. However, the title and description indicate a version bump to v8.5.4. Please ensure the PR's title and description accurately reflect the changes. My review includes a suggestion to add a newline at the end of the new file, which is a common convention for text files.

@Oreoxmt
Copy link
Collaborator

Oreoxmt commented Nov 18, 2025

/cc @Oreoxmt

@ti-chi-bot ti-chi-bot bot requested a review from Oreoxmt November 18, 2025 07:00
@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 07:01:13.804755927 +0000 UTC m=+1376723.247785806: ☑️ agreed by Oreoxmt.

@qiancai qiancai self-assigned this Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiancai. For more information see the Code Review Process.
Please ensure that each of them provides their approval before proceeding.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai force-pushed the bump-to-v8.5.4-21085 branch from 03304e2 to 24e2bd2 Compare November 20, 2025 01:57
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 20, 2025

@Oreoxmt: Your lgtm message is repeated, so it is ignored.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants