Skip to content

Conversation

@ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #22031

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions (in Chinese).

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot ti-chi-bot added lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR. labels Nov 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the documentation for TiCDC's new architecture, providing clearer guidance on its deployment and monitoring. It distinguishes between automatic and manual steps for integrating the new architecture's monitoring dashboard based on TiDB cluster versions and offers detailed instructions for deploying TiCDC nodes using both TiUP and TiDB Operator. The updates aim to improve user experience by providing precise, version-aware information.

Highlights

  • Monitoring Dashboard Integration: Clarified that the 'TiCDC-New-Arch' monitoring dashboard is automatically integrated for TiDB clusters v8.5.4 and later, removing the need for manual import in these cases.
  • Deployment Instructions: Added comprehensive deployment guides for the new TiCDC architecture, covering both new TiDB cluster deployments and adding TiCDC nodes to existing clusters, with specific instructions for TiUP and TiDB Operator.
  • Architecture Compatibility: Emphasized that the new TiCDC architecture maintains compatibility with the configuration, usage, and APIs of the classic TiCDC architecture.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation for TiCDC's new architecture, clarifying version-specific behaviors for monitoring dashboards and deployment procedures. The changes improve the structure and clarity of the documents. I've suggested a minor grammatical correction to improve readability.

@qiancai qiancai changed the base branch from release-8.5 to feature/preview-v8.5.4 November 18, 2025 07:26
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@qiancai
Copy link
Collaborator

qiancai commented Nov 18, 2025

/approve

1 similar comment
@qiancai
Copy link
Collaborator

qiancai commented Nov 18, 2025

/approve

@ti-chi-bot ti-chi-bot bot added the approved label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: qiancai

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiancai qiancai changed the title cdc: update description about new architecture (#22031) v8.5.4: cdc: update description about new architecture (#22031) Nov 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit ab01f1c into pingcap:feature/preview-v8.5.4 Nov 18, 2025
9 checks passed
@ti-chi-bot ti-chi-bot bot deleted the cherry-pick-22031-to-release-8.5 branch November 18, 2025 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-8.5 This PR is cherry-picked to release-8.5 from a source PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants