Skip to content

Conversation

@hfxsd
Copy link
Collaborator

@hfxsd hfxsd commented Nov 18, 2025

First-time contributors' checklist

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v9.0 (TiDB 9.0 versions)
  • v8.5 (TiDB 8.5 versions)
  • v8.1 (TiDB 8.1 versions)
  • v7.5 (TiDB 7.5 versions)
  • v7.1 (TiDB 7.1 versions)
  • v6.5 (TiDB 6.5 versions)
  • v6.1 (TiDB 6.1 versions)
  • v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@hfxsd hfxsd self-assigned this Nov 18, 2025
@ti-chi-bot ti-chi-bot bot added the contribution This PR is from a community contributor. label Nov 18, 2025
@hfxsd hfxsd requested a review from lilin90 November 18, 2025 10:06
@ti-chi-bot ti-chi-bot bot added missing-translation-status This PR does not have translation status info. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2025
@hfxsd hfxsd added needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 18, 2025
@gemini-code-assist
Copy link

Summary of Changes

Hello @hfxsd, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on a significant terminology refinement within the documentation. The word "illegal" has been systematically replaced with "invalid" to provide more accurate and consistent language when referring to data, values, or operations that do not conform to expected rules or formats. This change enhances the precision of the documentation, making it clearer for users to understand error conditions and system behaviors.

Highlights

  • Terminology Consistency: The term "illegal" has been consistently replaced with "invalid" across various documentation files to improve clarity and precision in describing data states or operations that are not permissible.
  • Documentation Updates: Numerous documentation pages, including those related to character sets, SQL modes, literal values, and release notes, have been updated to reflect this terminology change.
  • Impact on Specific Features: Changes affect descriptions of character compatibility (GBK), SQL mode behavior (ONLY_FULL_GROUP_BY, strict modes), handling of hexadecimal and bit-value literals, and various bug fixes mentioned in release notes concerning data types, memory access, and optimizer hints.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consistently replaces the term "illegal" with "invalid" across numerous documentation files, which is a commendable effort to improve terminology consistency. The changes are mostly accurate and enhance the clarity of the documentation. I have identified a few areas for further improvement, including a suggestion for conciseness, a recommendation for further terminological consistency, and one instance where reverting to "illegal" would be more appropriate for the context. Overall, this is a valuable and well-executed documentation update.

@lilin90 lilin90 added the translation/no-need No need to translate this PR. label Nov 18, 2025
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed missing-translation-status This PR does not have translation status info. labels Nov 18, 2025
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Copy link
Member

@lilin90 lilin90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Nov 18, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-11-18 10:19:25.441379572 +0000 UTC m=+6929.090574029: ☑️ agreed by lilin90.

@hfxsd hfxsd added the lgtm label Nov 18, 2025
@hfxsd
Copy link
Collaborator Author

hfxsd commented Nov 18, 2025

/approve

@ti-chi-bot
Copy link

ti-chi-bot bot commented Nov 18, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Nov 18, 2025
@ti-chi-bot ti-chi-bot bot merged commit 3a64b22 into pingcap:master Nov 18, 2025
8 of 9 checks passed
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created to branch release-8.5: #22065.

ti-chi-bot bot pushed a commit that referenced this pull request Nov 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved contribution This PR is from a community contributor. lgtm needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-cherry-pick-release-8.5 Should cherry pick this PR to release-8.5 branch. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. translation/no-need No need to translate this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants