tidb-cloud: add configuring storage access for Premium #22072
Conversation
lilin90
added
translation/no-need
ti-chi-bot
bot
added
the
size/L
Summary of ChangesHello @lilin90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the documentation for configuring external storage access in TiDB Cloud. It involves renaming a core document to a more general title and enhancing its content to support the Premium tier, alongside the existing Starter and Essential tiers. The changes ensure that users across all TiDB Cloud offerings have accurate and consistent guidance for integrating with external storage services like Amazon S3, GCS, Azure Blob Storage, and Alibaba Cloud OSS. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request refactors the documentation for external storage access by renaming a key file and updating its content to include instructions for TiDB Cloud Premium. The changes also involve updating links across multiple files to reflect the new filename. My review focuses on the clarity, consistency, and formatting of the updated documentation, providing suggestions to improve readability and remove minor formatting issues like extra whitespace and inconsistent line breaks.
| 5. After the CloudFormation stack is executed, you can click the **Outputs** tab and find the Role ARN value in the **Value** column. | ||
|
|
||
|  | ||
|  |
There was a problem hiding this comment.
Great job adding descriptive alt text for the image! This improves accessibility.
[LGTM Timeline notifier]Timeline:
|
Co-authored-by: Grace Cai <qqzczy@126.com>
|
@wildpcww: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: lilin90 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
What is changed, added or deleted? (Required)
/tidb-cloud/serverless-external-storage.mdto/tidb-cloud/configure-external-storage-access.md/tidb-cloud/configure-external-storage-access.mdto make it applicable to PremiumWhich TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?