.github: check connectivity of external links via GitHub action #4135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yikeke
added
needs-cherry-pick-2.1
translation/from-docs-cn
|
hi @CaitinChen , the check reports some invalid URLs again in the docs repo. I need your help to fix URLs in the
|
|
For the broken links reported above, see their correct URLs:
@queenypingcap Do we need someone to review the Adopters list, since it might have out-of-date information? |
yikeke
commented
Nov 3, 2020
| |[Meili Finance](https://www.crunchbase.com/organization/meili-jinrong)|FinTech|| | ||
| |[Guolian Securities](https://www.crunchbase.com/organization/guolian-securities)|Financial Services|| | ||
| |[Founder Securities](https://www.linkedin.com/company/founder-securities-co-ltd-/)|Financial Services|| | ||
| |[Founder Securities](https://www.crunchbase.com/organization/keruyun-technology-beijing-co-ltd)|Financial Services|| |
|
@WT-Liu FYI. |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-2.1 in PR #4136 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-3.0 in PR #4137 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-3.1 in PR #4138 |
ti-srebot
pushed a commit
to ti-srebot/docs
that referenced
this pull request
Nov 3, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
9 tasks
|
cherry pick to release-4.0 in PR #4139 |
yikeke
added a commit
that referenced
this pull request
Nov 3, 2020
… (#4136) * cherry pick #4135 to release-2.1 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix * Update link-check.yaml * Update tune-operating-system.md * Revert "Update tune-operating-system.md" This reverts commit 49ebd44. * Update link-check.yaml Co-authored-by: Keke Yi <40977455+yikeke@users.noreply.github.com> Co-authored-by: yikeke <yikeke@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is changed, added or deleted? (Required)
A migration from pingcap/docs-dm#353
Note this external link check isn't required to pass, in order to prevent false alarms from blocking PR merge.
The current regex exclusions is:
http://172.*|https://github.com/.*/pull/.*|https://github.com/.*/issues/.*|https://github.com/[^.\n]*$|http://127.0.0.1.*|http://localhost.*|http://.*:.*|https://static.googleusercontent.com/media/research.google.com/.*|.*.mdMeaning the check will skip checking the URLs matching the above patterns.
Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?