Skip to content

Fix wrong default value in tiflash config doc #4250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 19, 2020
Merged

Fix wrong default value in tiflash config doc #4250

merged 1 commit into from
Nov 19, 2020

Conversation

@TomShawn
Copy link
Contributor

@TomShawn TomShawn commented Nov 17, 2020 •
edited
Loading

What is changed, added or deleted? (Required)

  • Support INFORMATION_SCHEMA.PARTITION since 4.0.8
  • Fix wrong default value in tiflash config doc

Which TiDB version(s) do your changes apply to? (Required)

  • master (the latest development version)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Have version specific changes
  • Might cause conflicts

@TomShawn TomShawn added translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn. size/small Changes of a small size. status/PTAL This PR is ready for reviewing. needs-cherry-pick-4.0 labels Nov 17, 2020
@TomShawn TomShawn requested a review from ran-huang November 17, 2020 09:58
@ti-srebot ti-srebot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 19, 2020
@TomShawn TomShawn merged commit ea1aab6 into pingcap:master Nov 19, 2020
@TomShawn TomShawn deleted the partitiontable-tiflash-value branch November 19, 2020 02:27
ti-srebot pushed a commit to ti-srebot/docs that referenced this pull request Nov 19, 2020
@TomShawn @ti-srebot
cherry pick pingcap#4250 to release-4.0
fd5d3e7 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Nov 19, 2020
Merged
9 tasks
@ti-srebot
Copy link
Contributor

cherry pick to release-4.0 in PR #4251

TomShawn added a commit that referenced this pull request Nov 19, 2020
@ti-srebot @TomShawn
cherry pick #4250 to release-4.0 (#4251)
d7aa1c2 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@ran-huang ran-huang ran-huang approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

size/small Changes of a small size. status/LGT1 Indicates that a PR has LGTM 1. status/PTAL This PR is ready for reviewing. translation/from-docs-cn This PR is translated from a PR in pingcap/docs-cn.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TomShawn @ti-srebot @ran-huang