Skip to content

Conversation

@morgo
Copy link
Contributor

@morgo morgo commented Oct 29, 2021

What is changed, added or deleted? (Required)

TiDB does not support EXPLAIN FORMAT=tree. It comes from MySQL 8.0, so it had not previously been documented (our official claim = 5.7), but users might not know this. So it helps to include it here.

Note: I've updated this to cover optimizer switch compatibility as well. In pingcap/tidb#29040 we determined that optimizer_switch should be read_only for now.

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

  • master (the latest development version)
  • v5.2 (TiDB 5.2 versions)
  • v5.1 (TiDB 5.1 versions)
  • v5.0 (TiDB 5.0 versions)
  • v4.0 (TiDB 4.0 versions)
  • v3.1 (TiDB 3.1 versions)
  • v3.0 (TiDB 3.0 versions)
  • v2.1 (TiDB 2.1 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Oct 29, 2021

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • TomShawn
  • dveeden

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@ti-chi-bot ti-chi-bot requested a review from TomShawn October 29, 2021 16:46
@morgo morgo requested review from dveeden and removed request for TomShawn October 29, 2021 16:46
@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
@ti-chi-bot ti-chi-bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 29, 2021
@morgo morgo changed the title sql-statements: update claims on explain compatibility sql-statements: update claims on optimizer/explain compatibility Oct 29, 2021
@morgo morgo requested a review from yudongusa October 29, 2021 16:58
@shichun-0415 shichun-0415 added area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. translation/doing This PR's assignee is translating this PR. needs-cherry-pick-release-5.0 and removed missing-translation-status This PR does not have translation status info. labels Nov 1, 2021
@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Nov 1, 2021
@yudongusa
Copy link

LGTM

@ti-chi-bot
Copy link
Member

@yudongusa: Thanks for your review. The bot only counts approvals from reviewers and higher roles in list, but you're still welcome to leave your comments.

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@morgo
Copy link
Contributor Author

morgo commented Dec 16, 2021

@TomShawn PTAL, thanks!

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@ti-chi-bot ti-chi-bot removed the status/LGT1 Indicates that a PR has LGTM 1. label Dec 20, 2021
@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Dec 20, 2021
@TomShawn
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: d44f95f

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Dec 20, 2021
@ti-chi-bot ti-chi-bot merged commit 9c8adc2 into pingcap:master Dec 20, 2021
@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7295.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7296.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7297.

@ti-chi-bot
Copy link
Member

In response to a cherrypick label: new pull request created: #7298.

TomShawn added a commit that referenced this pull request Dec 20, 2021
…) (#7298)

* sql-statements: update claims on explain compatibility

* Add additional notes on optimizer

* Update mysql-compatibility.md

Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>

Co-authored-by: Morgan Tocker <tocker@gmail.com>
Co-authored-by: TomShawn <41534398+TomShawn@users.noreply.github.com>
@TomShawn TomShawn added translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR. and removed translation/doing This PR's assignee is translating this PR. labels Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sql-infra Indicates that the Issue or PR belongs to the area of sql-infra and sql-metadata. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT2 Indicates that a PR has LGTM 2. translation/done This PR has been translated from English into Chinese and updated to pingcap/docs-cn in a PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants