FAQ: update slow log, DDL and Syncer related questions #854
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilin90
reviewed
Jan 17, 2019
FAQ.md
Outdated
|
|
||
| 2. If a slow query occurs, you can locate the `tidb-server` instance where the slow query is and the slow query time point using Grafana and find the SQL statement information recorded in the log on the corresponding node. | ||
|
|
||
| 3. Besides the log, you can also view the slow query using the `admin show slow` command. For details, see [`admin show slow` command](sql/slow-query.md#admin-show-slow-command). |
There was a problem hiding this comment.
Suggested change
| 3. Besides the log, you can also view the slow query using the `admin show slow` command. For details, see [`admin show slow` command](sql/slow-query.md#admin-show-slow-command). | |
| 3. In addition to the log, you can also view the slow query using the `admin show slow` command. For details, see [`admin show slow` command](sql/slow-query.md#admin-show-slow-command). |
There was a problem hiding this comment.
Please try to avoid using the word "besides". Reference: #505
FAQ.md
Outdated
| INSERT INTO mysql.user VALUES ("%", "root", "", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y", "Y"); | ||
| ``` | ||
| #### 4.1.5 Can TiDB provide services while Loader is running? |
There was a problem hiding this comment.
Suggested change
| #### 4.1.5 Can TiDB provide services while Loader is running? | |
| #### Can TiDB provide services while Loader is running? |
There was a problem hiding this comment.
We do not use the heading number in English FAQ :)
FAQ.md
Outdated
| #### 4.1.5 Can TiDB provide services while Loader is running? | ||
| Since Loader inserts the data logically, TiDB can provide services while it's running. But do not perform the related DDL operations. |
There was a problem hiding this comment.
Suggested change
| Since Loader inserts the data logically, TiDB can provide services while it's running. But do not perform the related DDL operations. | |
| Because Loader inserts the data logically, TiDB can provide services while it is running. But do not perform the related DDL operations. |
There was a problem hiding this comment.
- Use "because" instead of "since".
- Do not use contractions in the documentation, which might cause difficulty for translation and ambiguity.
FAQ.md
Outdated
| - Put the `syncer.meta` file in a relatively secure disk. For example, use disks with RAID 1. | ||
| - Restore the location information of history synchronization according to the monitoring data that Syncer reports to Prometheus regularly. But the location information might be inaccurate due to the delay when a large amount of data is synchronized. | ||
| ##### If the downstream TiDB data is not consistent with the MySQL data during Syncer's synchronization process, will DML operations cause exits? |
There was a problem hiding this comment.
Suggested change
| ##### If the downstream TiDB data is not consistent with the MySQL data during Syncer's synchronization process, will DML operations cause exits? | |
| ##### If the downstream TiDB data is not consistent with the MySQL data during Syncer synchronization process, will DML operations cause exits? |
There was a problem hiding this comment.
Generally, do not use 's to show the possessive form of inanimate objects. You can omit it or use of.
FAQ.md
Outdated
| ##### If the downstream TiDB data is not consistent with the MySQL data during Syncer's synchronization process, will DML operations cause exits? | ||
| - If data exists in the upstream MySQL and doesn't exist in the downstream TiDB, and the upstream MySQL performs the `UPDATE` or `DELETE` operation on this piece of data, it will not cause errors or exits and the data will not exist during Syncer's synchronization process. |
There was a problem hiding this comment.
Suggested change
| - If data exists in the upstream MySQL and doesn't exist in the downstream TiDB, and the upstream MySQL performs the `UPDATE` or `DELETE` operation on this piece of data, it will not cause errors or exits and the data will not exist during Syncer's synchronization process. | |
| - If the data exists in the upstream MySQL but does not exist in the downstream TiDB, when the upstream MySQL performs the `UPDATE` or `DELETE` operation on this row of data, Syncer will not report an error and the synchronization process will not exit, and this row of data does not exist in the downstream. |
FAQ.md
Outdated
| ##### If the downstream TiDB data is not consistent with the MySQL data during Syncer's synchronization process, will DML operations cause exits? | ||
| - If data exists in the upstream MySQL and doesn't exist in the downstream TiDB, and the upstream MySQL performs the `UPDATE` or `DELETE` operation on this piece of data, it will not cause errors or exits and the data will not exist during Syncer's synchronization process. | ||
| - If conflicts exist in the primary key indexes or the unique indexes in the downstream, preforming `UPDATE` will cause exits while performing `INSERT` will not. |
There was a problem hiding this comment.
Suggested change
| - If conflicts exist in the primary key indexes or the unique indexes in the downstream, preforming `UPDATE` will cause exits while performing `INSERT` will not. | |
| - If a conflict exists in the primary key indexes or the unique indexes in the downstream, performing the `UPDATE` operation will cause an exit while performing the `INSERT` operation will not cause an exit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Via: pingcap/docs-cn#1083 Comment addressed. PTAL. @lilin90