Skip to content

Conversation

@EricZequan
Copy link
Contributor

@EricZequan EricZequan commented Mar 26, 2025

What problem does this PR solve?

Issue Number: ref pingcap/tidb#54245

Problem Summary:

What is changed and how it works?

What's Changed:
After the optimization of pr: https://github.com/tidbcloud/tiflash-cse/pull/395, https://github.com/tidbcloud/tidb-cse/pull/1454, the column_id will be deprecated and rename to deprecated_column_id. Then, add 2 field to save some info for the optimization

// Persists the original vector column's type information (including nullability)
// to ensure correct data handling. This field is always populated with the column's
// schema metadata, regardless of whether enable_distance_proj is enabled.
optional ColumnInfo column = 21 [(gogoproto.nullable) = false];

// If enabled, the content of TableScan's vector output column (whose ID is column.id) will be removed and
// TableScan will read a distance column (whose id must be -2000) as replacement, TiFlash persistent layer
// does not need to really read the Vector data column when index has been built.
optional bool enable_distance_proj = 22 [(gogoproto.nullable) = false];

How it Works:

Related changes

  • PR to update pingcap/docs/pingcap/docs-cn:
  • Need to cherry-pick to the release branch

Signed-off-by: “EricZequan” <zequany33@gmail.com>
@breezewish
Copy link
Member

LGTM.

Please propose a PR in TiDB and TiFlash OSS for the migration of column_id → column, so that it will not block other people to use the latest tipb. After these 2 PRs are proposed, we will merge altogether.

@breezewish breezewish merged commit c78c7b3 into pingcap:master Mar 28, 2025
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants