-
Couldn't load subscription status.
- Fork 32
sqlreplay: add filename and line in the report table #930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping CI for Draft Pull Request. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #930 +/- ##
=======================================
Coverage ? 67.59%
=======================================
Files ? 135
Lines ? 13308
Branches ? 0
=======================================
Hits ? 8995
Misses ? 3696
Partials ? 617
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: YangKeao The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
[LGTM Timeline notifier]Timeline:
|
What problem does this PR solve?
Issue Number: close #929
Problem Summary:
When there's one replay error, we only record the connection ID and time, but no filename or line index, making it hard to locate the right traffic event.
What is changed and how it works:
fail.Check List
Tests
Notable changes
Release note
Please refer to Release Notes Language Style Guide to write a quality release note.