Skip to content

Conversation

@djshow832
Copy link
Collaborator

@djshow832 djshow832 commented Oct 8, 2025

What problem does this PR solve?

Issue Number: close #929

Problem Summary:
When there's one replay error, we only record the connection ID and time, but no filename or line index, making it hard to locate the right traffic event.

What is changed and how it works:

  • Add filename and line index in the report table fail.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
mysql> select sample_filename, sample_fileline from fail limit 3;
+------------------------------------------------------------------------------+-----------------+
| sample_filename                                                              | sample_fileline |
+------------------------------------------------------------------------------+-----------------+
| file:/Users/zhangming/Downloads/audit/tidb-audit-2025-09-14T19-09-54.411.log |              13 |
| file:/Users/zhangming/Downloads/audit/tidb-audit-2025-09-14T19-09-57.647.log |               6 |
| file:/Users/zhangming/Downloads/audit/tidb-audit-2025-09-14T19-09-57.352.log |               4 |
+------------------------------------------------------------------------------+-----------------+
3 rows in set (0.01 sec)

Notable changes

  • Has configuration change
  • Has HTTP API interfaces change
  • Has tiproxyctl change
  • Other user behavior changes

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 8, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@ti-chi-bot ti-chi-bot bot added size/M and removed size/S labels Oct 8, 2025
@ti-chi-bot ti-chi-bot bot added size/L and removed size/M labels Oct 9, 2025
@djshow832 djshow832 marked this pull request as ready for review October 9, 2025 07:41
@ti-chi-bot ti-chi-bot bot requested a review from bb7133 October 9, 2025 07:41
@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@b62b978). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #930   +/-   ##
=======================================
  Coverage        ?   67.59%           
=======================================
  Files           ?      135           
  Lines           ?    13308           
  Branches        ?        0           
=======================================
  Hits            ?     8995           
  Misses          ?     3696           
  Partials        ?      617           
Flag Coverage Δ
unit 67.59% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: YangKeao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the lgtm label Oct 9, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Oct 9, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-10-09 08:18:31.589260782 +0000 UTC m=+341900.620360110: ☑️ agreed by YangKeao.

@ti-chi-bot ti-chi-bot bot added the approved label Oct 9, 2025
@ti-chi-bot ti-chi-bot bot merged commit 054940c into pingcap:main Oct 9, 2025
6 checks passed
@djshow832 djshow832 deleted the report_line branch October 9, 2025 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add more fields in the report tables

3 participants